Repository navigation
Fix collect on caches that other tasks modify - #10
Merged
Merged
Conversation
`collect` sized its result from `length(c)` and then iterated a snapshot taken separately, so it threw when another task changed the cache in between. Caches now report an unknown iterator size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collect(c)sized its result fromlength(c)and then iterated a snapshot taken separately under the lock. When another task inserted, evicted or emptied in between,collectthrew anArgumentError. With 2 threads it threw 207 times in 20,000 calls on aClockCache. Caches now reportBase.SizeUnknown(), socollectfollows the snapshot.The new test collects while another task writes. It fails without the fix and passes with it, for every container.
Found while investigating lock-free hits (#9).
🤖 Generated with Claude Code