Skip to content

chore: update security scanning workflows - #2470

Open
haribabug wants to merge 3 commits into
developfrom
add-security-scanning-update
Open

haribabug wants to merge 3 commits into
developfrom
add-security-scanning-update

Conversation

@haribabug

Copy link
Copy Markdown
Contributor

Security Scanning Workflows — Update

This PR syncs the security scanning configuration with the latest version from
ROCm/rocm-repo-template.

The original "chore: add security scanning workflows" PR for this repository has already been merged;
this follow-up brings the following file(s) back in line with the template:

  • .github/workflows/pr-security-scan.yml
  • .github/workflows/weekly-security-scan.yml
  • .github/dependabot.yml
  • .github/scan_tools_configs/bandit.yml
  • .github/scan_tools_configs/gitleaks.toml
  • .github/scan_tools_configs/trivy.yml
  • .github/scan_tools_configs/zizmor.yml

Why

The template evolved after the initial rollout. This keeps this repository aligned
with the ROCm GitHub Organization Security Baseline.


For more details, refer ROCm GitHub Org Security Controls Baseline Architecture

Support/Questions: Teams Channel ROCm Security Discussions

Syncs 7 security scanning file(s) with the latest version
from ROCm/rocm-repo-template.
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Security scan found no critical or high findings on lines changed by this pull request

View the security scan run for complete reports.

“New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta.

Updates 8 security scanning file(s) to the latest version from
ROCm/rocm-repo-template.
@rmt-pr-reviewer rmt-pr-reviewer Bot added the modifies-ci-paths PR modifies the Claude review CI security perimeter; audit before applying claude-review label Oct 22, 2026
@rmt-pr-reviewer

Copy link
Copy Markdown

⚠️ This PR modifies the Claude-review CI security perimeter

The following files in this PR control whether and how the
claude-review workflow protects its LLM Gateway secrets at
runtime (see .github/workflows/CLAUDE_AUTO_REVIEW.md):

  • .github/workflows/pr-security-scan.yml
  • .github/workflows/weekly-security-scan.yml

Before applying the claude-review label on this PR, please:

  1. Audit the diff in these paths line-by-line. A malicious or
    accidental change could disable the --allowedTools
    restriction, the overlay step, the sanitizer, or the
    review/post job split -- any of which would expose the
    secrets in env to the PR-modified workflow.
  2. If the changes are legitimate and you want a Claude review,
    do NOT apply the claude-review label. Instead, run via
    Actions → Claude Auto Review → Run workflow and enter
    this PR's number. The dispatch path runs from the trusted,
    code-owner-approved version of the workflow on
    develop, so a malicious PR-side
    modification cannot affect the run.

(This banner is automated. The modifies-ci-paths label
will be removed automatically if a future push removes the
perimeter modifications. The Layer-3 in-workflow guard will
additionally fail the claude-review label-triggered run
on this PR if the label is applied while perimeter changes
are present.)

Pins the 'ROCm/rocm-security-gh' security baseline from the floating
'v1' tag to v1.0.8 (35d3060c4b2ed48f950f85bd414a1302a431fc0b) and removes the zizmor
unpinned-uses allow list entry for it. 3 file(s) changed.
@rmt-pr-reviewer

Copy link
Copy Markdown

⚠️ This PR modifies the Claude-review CI security perimeter

The following files in this PR control whether and how the
claude-review workflow protects its LLM Gateway secrets at
runtime (see .github/workflows/CLAUDE_AUTO_REVIEW.md):

  • .github/workflows/pr-security-scan.yml
  • .github/workflows/weekly-security-scan.yml

Before applying the claude-review label on this PR, please:

  1. Audit the diff in these paths line-by-line. A malicious or
    accidental change could disable the --allowedTools
    restriction, the overlay step, the sanitizer, or the
    review/post job split -- any of which would expose the
    secrets in env to the PR-modified workflow.
  2. If the changes are legitimate and you want a Claude review,
    do NOT apply the claude-review label. Instead, run via
    Actions → Claude Auto Review → Run workflow and enter
    this PR's number. The dispatch path runs from the trusted,
    code-owner-approved version of the workflow on
    develop, so a malicious PR-side
    modification cannot affect the run.

(This banner is automated. The modifies-ci-paths label
will be removed automatically if a future push removes the
perimeter modifications. The Layer-3 in-workflow guard will
additionally fail the claude-review label-triggered run
on this PR if the label is applied while perimeter changes
are present.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modifies-ci-paths PR modifies the Claude review CI security perimeter; audit before applying claude-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants