feat: Toolbox-Search add support for preset blocks - #2594
Merged
gonfunko merged 2 commits intoSep 8, 2025
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
gonfunko
approved these changes
Sep 8, 2025
Contributor
|
Thank you for the fix, this looks good! Once you sign the CLA I'll be happy to merge it. |
Contributor
Author
|
The CLA check seems to work now. I already signed the CLA before, but I missed the rescan option. |
Contributor
|
Ah perfect, thank you! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2593
Proposed Changes
Extend the toolbox-search plugin so that searches also include preset blocks defined in the toolbox.
Reason for Changes
Ensures consistent behavior: block configurations available in the toolbox should also appear in search results.
Test Coverage
The unit tests have been refactored to work with the changed
indexBlocksparameters. I also added a test case that validates the preset block behaviour.Documentation
Additional Information
I had to use the fix provided in #2578 for testing with the newest Blockly version.