Classify DNS resolution errors as IO_NETWORK - #109
Open
robertbuessow wants to merge 1 commit into
Open
Conversation
DNS failures (e.g. hickory-resolver's "dns error: proto error: no records found ...") didn't match any pattern in classify_message() and fell through to the INTERNAL catch-all, even though they're a network condition and should surface as IO_NETWORK like other connectivity failures. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dns error: proto error: no records found ...from hickory-resolver) didn't match any substring check inclassify_message()and fell through to theINTERNALcatch-all, even though it's a network-connectivity condition."dns error"to theIO_NETWORKpattern list so these classify consistently with other connection failures (refused/reset/timed out).Test plan
cargo testiniceberg_rust_ffi(existing error-classification tests intest/error_tests.jl/ Rust unit tests)IcebergException: IO_NETWORKinstead ofINTERNAL🤖 Generated with Claude Code