Repository navigation
fix: pair boot serial normalization with the selected runtime - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYSTEM.CNF boot names such as SLUSP012.06 and SLUSP013.46 must produce the same canonical serial in the builder and the runtime's mounted-disc report. Normalize them to SLUS-01206 and SLUS-01346 after a known territory prefix. Reject the unusual-name build when the selected runtime does not declare normalization version2; ordinary names continue to work with older runtimes. Both CHD and extracted-disc admission paths apply the check before generating a roster.
The public producer capability is in RetroPortingToolKit/psxrecomp#868 . This PR changes no supported-version defaults, core selection or release artifact. An older selected reader remains unsuitable for those unusual names and receives an explicit error.
Validation on current main4b4f1d05f9e7634e4b44a52e15b29c92bf34527c, Windows/Python3.14:
Developed with AI assistance; validated as described (test evidence in PR body). AI writes the code and the PR, but I always test before I send something up. Happy to iterate on this process with your feedback.