Repository navigation
fix: require fresh reports from each kit startup - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent psx_last_run_report.json from an earlier start can make the optional kit-start check pass even when the new game writes no report. Remove the report in both accepted locations immediately before each start. Stage2 must then receive fresh frames from that start.
The regression mocks the actual kit-start path: recent reports at the kit root and build-release must both be rejected, while a genuinely new report at either location is accepted. The unchanged base incorrectly accepts the old999-frame report; the fix rejects it. No actual program, GUI, audio or focus is started by these tests.
Validation on current main4b4f1d05f9e7634e4b44a52e15b29c92bf34527c, Windows/Python3.14:
Developed with AI assistance; validated as described (test evidence in PR body). AI writes the code and the PR, but I always test before I send something up. Happy to iterate on this process with your feedback.