Repository navigation
fix(asset): version marker to redownload assets when new version detected - #346
Merged
Merged
Conversation
get_prefix only checked that assets/scenes/empty_world/scene.xml exists. Assets in ~/.rcs were therefore never refreshed after an rcs-core upgrade (all installed versions shared the first downloaded assets), an interrupted download was accepted as complete, and packages reusing get_prefix with their own archive (e.g. duobench) re-downloaded their assets on every import because the RCS file is not part of it. download_assets now extracts into a staging directory next to the target, writes assets/.version and moves it into place, so concurrent processes never see partially written assets. get_prefix re-downloads when the version file is missing or differs from the requested version. An RCS_PREFIX with assets but without a version file (e.g. a source checkout) is used as it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.