[Web runtime] Add reconnect-on-close and HTTP retry to the Browser SDK - #1569
Open
minggangw wants to merge 2 commits into
Open
[Web runtime] Add reconnect-on-close and HTTP retry to the Browser SDK#1569minggangw wants to merge 2 commits into
minggangw wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the rclnodejs/web Browser SDK’s resilience by adding WebSocket reconnect-on-close with backoff and HTTP retry-with-backoff behavior, plus corresponding public typings and tests.
Changes:
- Implement WebSocket reconnect-on-close with exponential backoff + jitter, subscription replay, and lifecycle events (
disconnected/reconnecting/reconnected). - Add HTTP retry-with-backoff for
call()/publish()on network errors and 5xx responses viahttpRetries. - Add a new test suite covering WS reconnect behavior and HTTP retries.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| web/index.d.ts | Updates public types/docs to expose reconnect, httpRetries, and lifecycle event on/off APIs. |
| web/client.js | Implements reconnect/backoff logic (WS + HTTP), lifecycle event listeners, and wires new options into transports. |
| test/test-web-reconnect.js | Adds coverage for WS reconnect semantics and HTTP retry behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
131
to
135
| const onError = (err) => { | ||
| if (this._pending.size === 0 && !this._closed) { | ||
| // Ignore post-open: 'close' always follows and _handleClose() owns failing pending requests. | ||
| if (!settled) { | ||
| settled = true; | ||
| reject(err && err.error ? err.error : err); |
Comment on lines
+163
to
+178
| _handleClose() { | ||
| this._failAll(_connectionLostError()); | ||
| if (this._userClosed) { | ||
| this._closed = true; | ||
| this._subs.clear(); | ||
| return; | ||
| } | ||
| this._onEvent('disconnected', undefined); | ||
| if (!this._reconnect) { | ||
| this._closed = true; | ||
| this._subs.clear(); | ||
| return; | ||
| } | ||
| this._reconnecting = true; | ||
| this._scheduleReconnect(); | ||
| } |
Comment on lines
+517
to
+520
| /** | ||
| * Subscribe to an SDK lifecycle event: 'disconnected', 'reconnecting' | ||
| * ({attempt, delay}), or 'reconnected'. Only fires with {reconnect: true}. | ||
| */ |
Comment on lines
+244
to
+247
| if (!this._ws || this._closed) return; | ||
| const ws = this._ws; | ||
| // Already closed (e.g. mid-backoff) means 'close' won't fire again. | ||
| if (ws.readyState === 3) return; |
|
coverage: 91.093% (-0.009%) from 91.102% — minggangw:feat/web-sdk-reconnect into RobotWebTools:develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the
rclnodejs/webBrowser SDK’s resilience by adding WebSocket reconnect-on-close with backoff and HTTP retry-with-backoff behavior, plus corresponding public typings and tests.Changes:
disconnected/reconnecting/reconnected).call()/publish()on network errors and 5xx responses viahttpRetries.Fix: #1510