-
Notifications
You must be signed in to change notification settings - Fork 60
Websockets asyncio #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Websockets asyncio #152
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c9cabe8
Add selectable asyncio transport
gonzalocasas e358272
Parametrize ROS tests by transport
gonzalocasas a433585
lint
gonzalocasas c9638db
Send asyncio transport messages as text frames
gonzalocasas 0b00761
Queue asyncio transport sends
gonzalocasas 9820d95
Publish transport benchmark in CI
gonzalocasas 33c0ac2
Split transport benchmark workflow
gonzalocasas 24bca8e
Warm rosbridge before transport benchmark
gonzalocasas 5f2ec19
Benchmark uvloop and websocket compression
gonzalocasas a3e8d3a
Add Read the Docs configuration
gonzalocasas 5326f99
fix manifest
gonzalocasas f3cf1a0
Document benchmark result interpretation
gonzalocasas 0b32b34
Rework asyncio transport to use Autobahn instead of websockets
gonzalocasas 4df4fea
Tweak transport benchmark
gonzalocasas 6f4b9ca
Make benchmark also work on ROS 2
gonzalocasas c0cefdc
Merge branch 'main' of https://github.com/RobotWebTools/roslibpy into…
gonzalocasas a84f389
Bump versions of python in CI and classifiers
gonzalocasas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| name: Transport benchmark | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| tags: | ||
| - 'v*' | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| transport-benchmark: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - name: Set up Python 3.11 | ||
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: "3.11" | ||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| python -m pip install wheel | ||
| - name: Install | ||
| run: | | ||
| python -m pip install --no-cache-dir -r requirements-dev.txt | ||
| python -m pip install --no-cache-dir uvloop | ||
| - name: Set up docker containers | ||
| run: | | ||
| docker build -t gramaziokohler/rosbridge:integration_tests_ros1 ./docker/ros1 | ||
| docker run -d -p 9090:9090 --name rosbridge gramaziokohler/rosbridge:integration_tests_ros1 /bin/bash -c "roslaunch /integration-tests.launch" | ||
| docker ps -a | ||
| - name: Run transport benchmark | ||
| continue-on-error: true | ||
| run: | | ||
| python benchmarks/transport.py \ | ||
| --host 127.0.0.1 \ | ||
| --port 9090 \ | ||
| --cases twisted asyncio asyncio-uvloop asyncio-no-compression asyncio-uvloop-no-compression \ | ||
| --warmup 100 \ | ||
| --service-count 1500 \ | ||
| --topic-count 3000 \ | ||
| --markdown transport-benchmark.md | ||
| cat transport-benchmark.md >> "$GITHUB_STEP_SUMMARY" | ||
| - name: Upload transport benchmark | ||
| if: always() | ||
| continue-on-error: true | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: transport-benchmark | ||
| path: transport-benchmark.md | ||
| if-no-files-found: ignore | ||
| - name: Tear down docker containers | ||
| if: always() | ||
| run: | | ||
| docker rm -f rosbridge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| version: 2 | ||
|
|
||
| build: | ||
| os: ubuntu-22.04 | ||
| tools: | ||
| python: "3.11" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe a newer python? |
||
|
|
||
| sphinx: | ||
| configuration: docs/conf.py | ||
|
|
||
| python: | ||
| install: | ||
| - requirements: docs/requirements.txt | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 24?