Skip to content

Fix bytemuck feature after bitflags update - #638

Merged
Firestar99 merged 1 commit into
Rust-GPU:mainfrom
nazar-pc:fix-docs
Aug 5, 2026
Merged

Fix bytemuck feature after bitflags update#638
Firestar99 merged 1 commit into
Rust-GPU:mainfrom
nazar-pc:fix-docs

Conversation

@nazar-pc

@nazar-pc nazar-pc commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Docs were not checked in CI, but failed somehow after merging to main: https://github.com/Rust-GPU/rust-gpu/actions/runs/30995586739/job/92271767273.

Copy/Clone derived unconditionally, despite only being needed for bytemuck. Feel free to update if that is not desirable (I think it is though).

@Firestar99 Firestar99 changed the title Fix docs after bitflags update Fix bytemuck feature after bitflags update Aug 5, 2026
@nazar-pc
nazar-pc marked this pull request as draft August 5, 2026 10:09
@nazar-pc

nazar-pc commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Will have a bit better version in a moment

@nazar-pc
nazar-pc marked this pull request as ready for review August 5, 2026 10:11
@nazar-pc

nazar-pc commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Okay, better solution is to simply enable bytemuck feature on bitflags itself. But consider adding docs checks to PRs as well so this can be caught earlier in the future.

@Firestar99

Copy link
Copy Markdown
Member

I'm more concerned about this breaking change from bitflags v1 -> v2:

鈿狅笍 Traits

Generated flags types now derive fewer traits. If you need to maintain backwards compatibility, you can derive the following yourself:

#[derive(PartialEq, Eq, PartialOrd, Ord, Hash, Debug, Clone, Copy)]

We should probably derive all that, I'll add it along with a check for the bytemuck feature.

@nazar-pc

nazar-pc commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Makes sense

Comment thread crates/spirv-std/src/memory.rs
@Firestar99
Firestar99 enabled auto-merge August 5, 2026 12:53
@Firestar99
Firestar99 added this pull request to the merge queue Aug 5, 2026
Merged via the queue into Rust-GPU:main with commit cb2f3a5 Aug 5, 2026
23 checks passed
@nazar-pc
nazar-pc deleted the fix-docs branch August 6, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants