Repository navigation
Make the field API handle owned data by default - #413
Conversation
759f00a to
7902ef5
Compare
|
We may want to discuss offline. Do we see a situation where we want to expose non-owned dofs through the PCMS API? I'd suspect that information should only be used internally to perform evaluations, etc. |
7902ef5 to
d791077
Compare
d791077 to
a6c867e
Compare
a6c867e to
0a76c28
Compare
0a76c28 to
e1df792
Compare
|
We should be able to rewrite this using tag data fairly easily. |
@jacobmerson Which part are you referring to? Do you mean rewriting ghost synchronization to store the values as mesh tags? |
|
I mean anything inside the evaluator already knows that it is a field stored as Omega_h tags, so we can directly use the tag info rather than going through the higher level PCMS API. |
|
There is one point of mismatch here. I don't think we previously made the assumption that omega h Lagrange backend data must come from a mesh tag, at least it is not explicitly guaranteed by code. In the current synchronization implementation, I use Therefore, the evaluator should get ghost data from |
e1df792 to
d8b4def
Compare
jacobmerson
left a comment
There was a problem hiding this comment.
Based on offline discussion @Sichao25 will move the Omega_h data out of simple data into it's own FieldData type. SimpleData is intended to just be a really rough data type with pure arrays.
ed95d12 to
00786e8
Compare
|
The update of |
By default, the field API gives owned data access by default. The ghost data needs to be accessed from the backend. So far the only use case of the ghost data is in
OmegaHLagrangeEvaluator.