Skip to content

Make settings Save atomic and polish inspector controls - #5

Merged
VolkerChristian merged 2 commits into
mainfrom
codex/settings-polish
Oct 1, 2026
Merged

VolkerChristian merged 2 commits into
mainfrom
codex/settings-polish

Conversation

@VolkerChristian

Copy link
Copy Markdown
Member

Settings Save could leave part of a draft applied when replay failed, and compact inspector fields wasted space or clipped on Breeze. This PR makes failed replay restore the prior live project and remain retryable, moves source/Reset beside each compact field title, fixes the literal ampersand in the Preferences link, and removes the unused presenter assignment.

Two ordered commits:

  1. Formatting only in the six requested settings modules. AST identity is verified against ad4178d; E225/E231/E702 findings are zero. The PR B addendum corrects its compressed-code +106 figure to +482 formatted production lines, exceeding its original +150 ceiling.
  2. Functional fixes, with +34 net production lines against the formatting commit (ceiling +40). The universal ampersand guard also covers Qt standard buttons; their native keyboard shortcuts are preserved explicitly.

Validation on Linux, using the existing Xvfb/WM driver and null audio sinks:

  • Formatting commit: 561 passed on stock Qt 6.11.2 and 561 passed on native Qt 6.10.2/Breeze.
  • Fix commit: 576 passed on each stack.
  • Replay faults after the first/middle mutation tested in defaults, talk and slide scopes, with clean/dirty windows: unchanged live state, draft, manifest bytes/mtime, and successful retry.
  • Ruff F checks clean; existing placement and tab-order tests pass.
  • 32 before/after screenshot pairs reviewed across both stacks, light/dark, 100%/150%, and both requested main-window sizes. Reset remains visible at 200 logical pixels of inspector content.

Full report, commands, accounting and failed attempts. This includes the first run's audio-state audit limitation. No runtime dependencies changed; Windows/macOS were not tested. The Qt bug-report work is separate from this PR.

@VolkerChristian
VolkerChristian merged commit e6e13a0 into main Oct 1, 2026
0 of 6 checks passed
@VolkerChristian
VolkerChristian deleted the codex/settings-polish branch October 15, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant