Repository navigation
Phase 2: adopt shared Verify for snode.c - #266
Merged
Merged
Conversation
VolkerChristian
marked this pull request as ready for review
October 10, 2026 16:42
VolkerChristian
added a commit
that referenced
this pull request
Oct 12, 2026
Phase 2: adopt shared Verify for snode.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2: first product enrollment
x-sdkpublisher (default branch only,contents: writescoped to unsigned rollingdevprerelease/tag).Verified locally: GCC 15.3.0/trixie build, 212/212 tests as unprivileged snodec, changed C++ formatting/whitespace/actionlint. The staged installation also passes a relocated installed-consumer test with producer paths absent.
Merge order: first product after control release. Require green default-branch Verify and actual dev SDK publication before merging consumers.
Coordination — do not merge yet
Depends on control PR #2, followed by the maintainer publishing its reviewed shared-workflow version and moving the existing
v1.0in SNodeC/.github. The existingv1.0has now been moved to the merged control commit; callers use@v1.0. Only the existing control workflow tag was moved with explicit approval; no new version tag was created. The seven-line read-only Verify caller remains the proposed template. Build details live only in.snodec/repo.yml.No package workflow/pipeline, secrets, stable release tags, licences, default-branch names, other repositories' READMEs or upstream forks are changed. README frames remain Phase 4. This is a draft migration, not a claim that Phase 2's default-branch gate is achieved.
Approved tag-reference update
The maintainer explicitly requested moving the already existing workflow tag rather than creating v1. The existing v1.0 tag in SNodeC/.github now points to merged control/tag-reference PR #3 (8914a66cb34ae0fe003ff9d0fe5a69dadfcc3060). The canonical template and all callers use @v1.0. No
v1tag was created and noBook-*tag was changed. CodexUI/AutoTalk test fixes remain explicitly deferred, with tests enabled.