[WIP] String copies refactor - #41
Draft
mtsokol wants to merge 2 commits into
Draft
Conversation
mtsokol
requested review from
jczuchnowski and
vpavkin
and removed request for
jczuchnowski
September 10, 2020 15:04
Contributor
|
Hey @mtsokol ! Great that you're working on this one. |
Author
|
While getting acquainted with code I changed minor borrow-related bits to avoid more copying - thought they got corrected but might be wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
While learning I'm trying to address #4. Here I think we avoid few copies, I only looked at
replace_fiber_dumpand I plan to look attree_list_widgettomorrow. I still don't get the exact difference into_ownedfor our case.