Skip to content

Fixed host UTXOs not being release properly during contract formation - #489

Merged
n8mgr merged 1 commit into
masterfrom
nate/fix-bugs
Oct 30, 2026
Merged

n8mgr merged 1 commit into
masterfrom
nate/fix-bugs

Conversation

@n8mgr

@n8mgr n8mgr commented Oct 30, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI balanced review requested due to automatic review settings October 30, 2026 15:27

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

Claude Code Review is paused for this repository because its GitHub organization is not linked to your Claude organization.

To turn it back on, one person needs both roles: owner of the GitHub organization (or the account owner, for a personal repository) and admin or owner of your Claude organization. If that is not you, pass this on to someone who is.

Open Organization settings, Git providers and click Link next to the GitHub organization's name. If it is not listed, click Enable GitHub integration or Connect your GitHub first, whichever the page shows.

New pull requests are then reviewed as before. To get a review on one that is already open, someone with write access can comment @claude review.

Tip: disable this comment in your organization's Code Review settings.

@n8mgr
n8mgr merged commit c55ef14 into master Oct 30, 2026
19 of 20 checks passed
@n8mgr
n8mgr deleted the nate/fix-bugs branch October 30, 2026 15:33
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Sia Oct 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Regression coverage is missing for consensus-validation rejection and peer fallback, including all-invalid responses, and for host-input cleanup after failed basis updates across formation, refresh, and renewal.

2 open issues
What changed in this PR

Fixes host input reservations remaining locked after failed RHP v4 contract formation, refresh, or renewal. The PR also adds checkpoint validation and updates the exhaustive-struct linter configuration.

Changes:

  • Preserve funded host inputs for cleanup when a contract transaction is not broadcast.
  • Reject checkpoints that fail consensus validation and continue processing peer responses.
  • Migrate to exhaustruct_v5 and add patch changesets for both fixes.
File Description
syncer/​syncer.go Validate checkpoints before returning them.
rhp/​v4/​server.go Release captured host inputs on failed contract operations.
.golangci.yml Migrate exhaustive-struct linting configuration.
.changeset/​properly_release_host_inputs_on_failed_formations_and_renewals.md Add a patch release note for host-input cleanup.
.changeset/​fixed_issue_with_retrieve_checkpoint.md Add a patch release note for checkpoint retrieval.

Review effort: Balanced

Comment thread rhp/v4/server.go Resolved
Comment thread syncer/syncer.go Resolved
@n8mgr n8mgr mentioned this pull request Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants