SONOFF/SWV1C by yanggx24 · Pull Request #3157 · SmartThingsCommunity/SmartThingsEdgeDrivers

yanggx24 · 2026-07-31T05:46:07Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

KKlimczukS · 2026-07-31T09:24:11Z

@@ -0,0 +1,14 @@
+name: sonoff-irrigation


Please rename this profile to valve-battery

KKlimczukS · 2026-07-31T09:41:20Z

+    [capabilities.valve.ID] = {
+      [capabilities.valve.commands.open.NAME] = valve_open_handler,
+      [capabilities.valve.commands.close.NAME] = valve_close_handler,
+    }
+  },


Did You check if Your device works with the zigbe-valve driver default handling ? (without this custom handling)

KKlimczukS · 2026-07-31T09:54:58Z

+      [OnOff.ID] = {
+        [OnOff.attributes.OnOff.ID] = onoff_attr_handler
+      },


Did You check if Your device works with the zigbe-valve driver default handling ? (without this custom handling)

github-actions · 2026-07-31T09:55:40Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2026-07-31T09:55:40Z

Profile category check: ✅ Passed - all profiles have a category defined.

github-actions · 2026-07-31T09:56:19Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/gV2qEO1Qp929

github-actions · 2026-07-31T09:57:14Z

zigbee-valve_coverage.xml

File	Coverage
All files	`88%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-valve/src/sinope/init.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-valve/src/sonoff/init.lua	`73%`	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 244e0ee

github-actions · 2026-07-31T09:57:20Z

Test Results

73 files 541 suites 0s ⏱️
3 241 tests 3 236 ✅ 0 💤 5 ❌
5 233 runs 5 227 ✅ 0 💤 6 ❌

For more details on these failures, see this check.

Results for commit 244e0ee.

♻️ This comment has been updated with latest results.

yanggx24 · 2026-08-01T03:02:58Z

Thanks for the review.

Yes, I checked this behavior with the SONOFF SWV1C device. The device uses the Zigbee OnOff cluster for valve control and reports the valve state through the OnOff attribute.

The custom handlers were added to explicitly map:

valve.open / valve.close commands to Zigbee OnOff On / Off
OnOff attribute reports back to SmartThings valve.open / valve.closed events

This is also needed because the device reports the OnOff value as ZCL_DATA_TYPE_UINT8. In Lua, numeric 0 is truthy, so the handler explicitly checks for false and 0 to avoid treating an OFF report as open.

I can also re-test without the custom handlers and confirm whether the default zigbee-valve handling covers this device correctly.

ldeora · 2026-08-03T08:16:04Z

I can also re-test without the custom handlers and confirm whether the default zigbee-valve handling covers this device correctly.

Has this implementation been tested with the valve left open for longer than ten minutes?

Several Hydro ONE users have reported that the valve closes itself after approximately ten minutes because of its device-side manual watering duration. From the current PR, it appears that Open only sends the standard Zigbee On command and does not read or update the SONOFF 0xFC11 attribute 0x501D (manualDefaultSettings).

Could you confirm whether the tested devices remained physically open beyond ten minutes, and which model and firmware version were used? It would also be useful to know whether newer firmware has removed the default limit or whether the WWST integration is expected to configure 0x501D.

yanggx24 · 2026-08-03T10:22:53Z

I can also re-test without the custom handlers and confirm whether the default zigbee-valve handling covers this device correctly.

Has this implementation been tested with the valve left open for longer than ten minutes?

Several Hydro ONE users have reported that the valve closes itself after approximately ten minutes because of its device-side manual watering duration. From the current PR, it appears that Open only sends the standard Zigbee On command and does not read or update the SONOFF 0xFC11 attribute 0x501D (manualDefaultSettings).

Could you confirm whether the tested devices remained physically open beyond ten minutes, and which model and firmware version were used? It would also be useful to know whether newer firmware has removed the default limit or whether the WWST integration is expected to configure 0x501D.

Just now, I tested a 10-minute manual valve opening action, and after the timeout, the device reported an off status, and the UI on the app also updated accordingly.
The firmware version of the tested device is v 1.1.0.
This smartthings driver will not affect the automatic shutdown after 10 minutes. For this device, our plan is to first complete the WWST certification, and then provide more support for private attributes.

ldeora · 2026-08-03T10:40:23Z

I can also re-test without the custom handlers and confirm whether the default zigbee-valve handling covers this device correctly.

Has this implementation been tested with the valve left open for longer than ten minutes?
Several Hydro ONE users have reported that the valve closes itself after approximately ten minutes because of its device-side manual watering duration. From the current PR, it appears that Open only sends the standard Zigbee On command and does not read or update the SONOFF 0xFC11 attribute 0x501D (manualDefaultSettings).
Could you confirm whether the tested devices remained physically open beyond ten minutes, and which model and firmware version were used? It would also be useful to know whether newer firmware has removed the default limit or whether the WWST integration is expected to configure 0x501D.

Just now, I tested a 10-minute manual valve opening action, and after the timeout, the device reported an off status, and the UI on the app also updated accordingly.

To make it clear: the valve won't stay open for longer than 10 minutes, even when it was opened "manually" (Zigbee On command)?

yanggx24 · 2026-08-04T01:40:57Z

To make it clear: the valve won't stay open for longer than 10 minutes, even when it was opened "manually" (Zigbee On command)?

Yes.

aleclorimer · 2026-08-04T17:46:49Z

-  sub_drivers = require("sub_drivers"),
-  health_check = false,
-  shared_device_thread_enabled = true,


Add the new sonoff subdriver to the sub_drivers.lua file in this driver and use lazy loading.

aleclorimer · 2026-08-04T17:47:25Z

-  health_check = false,
-  shared_device_thread_enabled = true,


These should be kept

feat:sonoff swv valve

d3ca759

KKlimczukS requested changes Jul 31, 2026

View reviewed changes

KKlimczukS reviewed Jul 31, 2026

View reviewed changes

KKlimczukS requested a review from cbaumler July 31, 2026 09:59

Zigbee Valve:modify comment language and file name

244e0ee

yanggx24 force-pushed the main branch from 53138de to 244e0ee Compare August 1, 2026 02:44

KKlimczukS mentioned this pull request Aug 3, 2026

[WWSTCERT-12824, WWSTCERT-12828, WWSTCERT-12832, WWSTCERT-12836] fingerprints for Sonoff valves #3027

Closed

13 tasks

cbaumler requested review from aleclorimer, cjswedes and nand-nor August 4, 2026 17:01

aleclorimer reviewed Aug 4, 2026

View reviewed changes

Uh oh!

Conversation

yanggx24 commented Jul 31, 2026

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

KKlimczukS Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KKlimczukS Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

KKlimczukS Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

yanggx24 commented Aug 1, 2026

Uh oh!

ldeora commented Aug 3, 2026

Uh oh!

yanggx24 commented Aug 3, 2026

Uh oh!

ldeora commented Aug 3, 2026

Uh oh!

yanggx24 commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aleclorimer Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

aleclorimer Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jul 31, 2026 •

edited

Loading

github-actions Bot commented Jul 31, 2026 •

edited

Loading

yanggx24 commented Aug 4, 2026 •

edited

Loading