Repository navigation
Conversation
|
What about |
|
Thanks for pointing these out. The Vulkan spec describes pImageInfo, pBufferInfo, and pTexelBufferView as selected by descriptorType; the two unused pointers are ignored. Based on that, I extended the parser override to make all three pointers nullable when unused and expanded the regression test to cover each one. The focused test failed against the old parser behavior and passes with this change. In an isolated, network-disconnected container using the same Zig master build recorded by the official download index, the focused parser regression passed, zig build test passed (11/11), and zig fmt --check . passed. git diff --check and patch policy also passed. GitHub checks had not appeared yet in the post-push readback. |
|
thanks |
Summary
VkWriteDescriptorSet.pImageInfois unused for non-image descriptor types, but the Vulkan registry does not mark this member optional. The generator therefore emitted a non-null Zig pointer and rejected a valid null value. Mark this specific generated field nullable.Evidence
nulltop_image_infofailed:expected type '[*]const DescriptorImageInfo', found '@TypeOf(null)'.?[*]const DescriptorImageInfo = null; the same probe passes (1/1).zig build -Dregistry=/registry/vk.xml testpassed in an isolated, no-network container.zig fmt --check src/vulkan/parse.zigandgit diff --checkpassed.Merge Danger
Door: two-way
Blast Radius: narrow
Consumers that read
p_image_infomust handle its nullable type. The change is limited to the generated representation of this one conditional pointer.Closes #149