SONARJAVA-6710: Fix FN on empty condition loop

[joke1196]

Part of

---

Summary by Gitar

• Bug fix:
  • Fixed false negative in LoopExecutingAtMostOnceCheck for empty condition for(;;) loops by requiring conditional control flow in the body
• Tests:
  • Added test cases covering various conditional structures and scope boundaries like lambdas and anonymous classes

_{This will update automatically on new commits.}

[hashicorp-vault-sonar-prod]

SONARJAVA-6710

[gitar-bot]

Code Review ✅ Approved 1 resolved / 1 findings

Fixes a false negative in LoopExecutingAtMostOnceCheck for empty condition for loops by requiring conditional control flow in the body, and addresses the switch-expression test isolation finding.

✅ 1 resolved

✅ Quality: Switch-expression test not isolated to the feature it verifies

📄 java-checks/src/test/files/checks/LoopExecutingAtMostOnceCheck.java:341-351
The switch-expression case at lines 342-351 also contains an if (x > 15) { break; }. Because containsConditional returns true on encountering either the switch expression or the if, this test would still be reported Compliant even if visitSwitchExpression detection regressed, so it does not actually guard switch-expression handling. Consider removing the if (leaving only the switch-expression assignment before the final break) so the test isolates the feature under test.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube