Repository navigation
Accept pylibsparseir 0.15; release 2.1.8 - #98
Merged
Merged
Conversation
pylibsparseir 0.15.0 changed no declaration in sparseir.h: the header at v0.15.0 is byte-identical to v0.14.0 (403 lines). The two fixes in that release are inside existing entry points, so the declared range only needs its upper bound raised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepts
pylibsparseir0.15 and releases 2.1.8 (range-only change, so both in one PR).Range:
>=0.8.3,!=0.13.*,<0.16.0(was<0.15.0), inpyproject.tomland both.conda/meta.yamlrequirements;check_libsparseir_version_consistency.pypasses.Why the upper bound only. The C header at
v0.15.0is byte-identical tov0.14.0— 403 lines,cmpclean after stripping comments:The two changes in 0.15.0 are inside existing entry points:
spir_sve_result_from_matrix_centrosymmetricruns its SVD in double-double againwhen the low parts are supplied (SpM-lab/sparse-ir-rs#293), and the Fortran
binding checks FMA before its first numerical call (#353). No signature, no
status code, no new symbol — so nothing in the
ctypeslayer changes and olderbackends keep working.
Tests (
uv run --with 'pylibsparseir==X' pytest tests/ -q):test_boundary.py::test_c_library_failure_surfaces_as_exceptionThe 0.8.3 failure is pre-existing and unrelated: the same test fails on
mainlinewith this change stashed. This PR does not touch the lower bound.pylibsparseir0.15.0 is on PyPI and in thespm-labconda channel, so CIresolves it.