Deploy query releases to GitHub Pages and enforce UTF-8 reports - #67
Open
martinsohn wants to merge 2 commits into
Open
Deploy query releases to GitHub Pages and enforce UTF-8 reports#67martinsohn wants to merge 2 commits into
martinsohn wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-report.mdexplicitly as UTF-8 to handle non-ASCII query content consistently.Queries.jsonas a GitHub Pages artifact.SpecterOps/BloodHoundQueryLibraryrepository.Motivation
queries.specterops.io loads the catalog from:
https://specterops.github.io/BloodHoundQueryLibrary/Queries.jsonThe release workflow generated an up-to-date
Queries.jsonfor GitHub releases, but did not update the Pages copy. This caused queries.specterops.io to use an older query catalog.Explicit UTF-8 output also prevents test-report generation from depending on the runner's default encoding.
Expected behavior
After a successful push to
main:Queries.jsonandQueries.zipare generated for the draft release.Queries.jsonis uploaded and deployed to GitHub Pages.Release and deployment jobs are skipped in forks. No query definitions or platform behavior are changed.
Testing
git diff --checkpasses.Queries.jsonwith the YAML files underqueries/.Deployment note
GitHub Pages is configured to use GitHub Actions as its publishing source.