Update Muon to 0.5.0 - #1095
Conversation
Issues Found
Next Steps
Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️ |
|
Issue "Both testing boxes are present in your description. Please remove one of them per the Markdown comment above the testing section." has been resolved. |
|
This pull request is stale as no updates or testing reports have been posted within the last 7 days. Please ensure you are actively recruiting testers or resolving the issues discussed. If you do not remove the stale label or comment, this will be closed in 7 days. Please close this pull request if you need more time to resolve issues so we can keep our repo healthy. |
|
Still active, waiting on admins for final approval. |
|
The package.json in this PR is referring to a file that no longer exists on Valve's servers. When I try to install the plugin, there's no error but the plugin just doesn't appear in the list. Given that Valve only ever has the latest version of each package available on their mirror, is it a good idea to hardcode a dependency version in the plugin? See wtlnetwork/muon#35 for the upstream bug report. |
|
Closing PR while we address this bug. New PR to follow. |
Update Muon to 0.5.0
(Resubmission of stale PR)
This change adds an offline compatibility table to the plugin (populated by a JSON file fetched from our documentation repository: https://github.com/wtlnetwork/muon-docs). This is to allow people to view which games are compatible with our plugin while offline. The JSON file is cached locally on plugin load. The reason this JSON is dynamically fetched is to allow new games to be added to the list as they are tested without requiring a whole new package. I checked via Discord whether it is permissible to fetch JSON in this way, and the conclusion was that it would be allowed.
The change also adds an option to select a network channel and band (i.e. 2.4 GHz or 5 GHz). This is to allow a more reliable connection, and to allow people to avoid congested bands. To ensure compliance with the WiFi regulations of various countries, we have included only universally permitted channels: 1, 6, 11, 36, 40, 44 and 48.
We have also made adjustments to the firewall handling. Instead of amending the Steam Deck's main firewall zone, the plugin now creates a dedicated 'muon-hotspot' firewall zone which is associated with only the access point interface. This means that the necessary firewall rules to make access to locally-hosted game servers possible now only apply when Muon is active.
Task Checklist
Developer
Plugin
Backend
Yes: I am using a custom backend other than Python. (The plugin utilises Bash scripts in order to activate/deactivate the hotspot and perform networking tasks)
No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked. (The plugin depends on hostapd and dnsmasq in order to perform network operations - namely, activation/deactivation of the hotspot and service DHCP requests for clients. The binary files are correctly handled via the remote binary handling options withing the packages.json file)
No: I am using a custom binary that has all of it's dependencies statically linked.
Community
update: decky-game-settings: 1.2.x #924 (comment)
Update hltb-for-deck to 2.0.6 #923 (comment)
Update hltb-for-deck to 2.0.6 #923 (comment)
(These were filled in as part of our original PR in November. If the requirement is for two additional PRs to be tested per PR rather than overall, please let me know)
Testing
(Testing reports can be found in the original PR: #1075)