Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares the v2.8.1 release, addressing a self-hosted update edge case (first update from older versions not actually switching the running image) and adjusting generated self-host release assets so the shipped Compose file is pinned to an immutable candidate image while still allowing controlled overrides.
Changes:
- Ensure self-hosted
subboost updateconsistently runs candidate Compose operations against the intended candidate image (and persistsSUBBOOST_CANDIDATE_IMAGE). - Generate release
docker-compose.image.ymlassets with an immutable candidate-image default and add regression coverage for image precedence + asset generation. - Publish v2.8.1 version bumps and updated bilingual release notes.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Includes regression tooling tests in the Vitest suite. |
| test/regression/tooling/selfhost-release-assets.test.ts | Adds regression assertions for release Compose generation and marker validation. |
| scripts/selfhost-release-assets.cjs | Writes release Compose with ${SUBBOOST_CANDIDATE_IMAGE:-...} and exports the helper. |
| local/scripts/subboost.sh | Ensures update flow uses the candidate image consistently via compose_files_with_image and persists candidate image metadata. |
| local/scripts/selfhost-shell.test.ts | Adds regression coverage for candidate image precedence during update and rollback flows. |
| local/scripts/install.sh | Persists SUBBOOST_CANDIDATE_IMAGE during installation. |
| README.md | Updates version badge to 2.8.1. |
| README-CN.md | Updates version badge to 2.8.1. |
| package.json | Bumps root package version to 2.8.1. |
| package-lock.json | Updates lockfile versions to 2.8.1. |
| local/package.json | Bumps @subboost/local version to 2.8.1. |
| docs/release-notes.md | Publishes v2.8.1 bilingual release notes content. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if (count !== 1) { | ||
| throw new Error(`Expected exactly one SubBoost image marker in docker-compose.image.yml, found ${count}.`); | ||
| } | ||
| const resolvedImage = `image: ${"${SUBBOOST_CANDIDATE_IMAGE:-"}${image}}`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification