Repository navigation
feat: share exploration discoveries between an account's characters - #4
Merged
XxFran10xX merged 2 commits intoOct 18, 2026
Merged
Conversation
Shortly after a character's session starts, its journal gets the discoveries the account's other characters (alive or dead) and its journal from before characters made, except entries kept per character (research and the research achievements by default). A copied discovery runs only its reward lines that carry over, rewritten by shared_discoveries.rewards: Player EXP goes through RPCharacters' carryexp, so a capped class keeps it for later. One summary message replaces the per-discovery messages. Entries known only out of character get a common-sense line (knownOutOfCharacterOnlyAdvice). Existing config.yml and messages.yml files gain the new section and keys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 17, 2026
XxFran10xX
marked this pull request as ready for review
October 17, 2026 20:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exploration belongs to the account: a character gets the Codex discoveries its other characters made, with their Player EXP, while research stays per character.
What exists today and what is new
Already on
main(v2.13.0, what Main runs):Not on
main, added here:carryexp.Changes
shared_discoveriessection inconfig.yml, added to existing files on startup:keep_per_character: categories orcategory:discoveryentries that are not shared. Default:researchand the research achievements (5_research,10_research,25_research,all_research,full_codex), so a new character still earns research EXP by researching.rewards:from/torewrites. A copied discovery runs only reward lines starting with afrom, rewritten toto. Default:mmocore admin exp give %player% main N→rpcharacter admin carryexp %player% N, so a capped class keeps the EXP. Messages, titles and sounds are skipped; onesharedDiscoveriesmessage replaces them. Completed categories pay theirall_discoverieslines the same way.Shared <n> Codex discoveries of account <account> with its character <character>.knownOutOfCharacterOnlyAdvice: "Use common sense: play as not knowing this until they learn it in character." (empty hides it). New message keys are added to existingmessages.yml.Related
carryexp, needed by the default rewrite)Tests
mvn verify: 45 tests, 100% line coverage ofnet.tfminecraft.codex.character. NewSharedExplorationTest, and sharing cases inCharacterJournalsTest(delay, dead characters, old account journal, research kept, offline/switched/quit players, failed save)./codex, C's Ignitium entry showed "Corra Stonemere knows this only out of character." and the common-sense line. On startup Codex added the config section and message keys to Dev's existing files.Not released yet; nothing on Main or Tutorial until the coordinated move.
🤖 Generated with Claude Code