Repository navigation
Build ConditionalEvents as a TFMC plugin for Paper 1.21.10 - #1
Merged
Merged
Conversation
Move the sources to net.tfminecraft.conditionalevents, build against Paper 1.21.10 with Java 21 and name the runtime jar conditionalevents-<version>.jar. ItemsAdder's API is no longer published, so build against the pinned ItemsAdder jar from ServerAssets like the other plugins. Add the shared workflows. Drop the update checker and bStats, which reported this copy as upstream ConditionalEvents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 14, 2026
Contributor
Author
|
Reviewed by Astra (GPT-6-Astra) over four read-only rounds together with the per-character PR; findings fixed. Muse was out of quota. Merging with admin bypass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up the new TF-Minecraft/ConditionalEvents copy of Ajneb97/ConditionalEvents 4.80.3, the same way as Codex #1. It is the groundwork for a per-event choice between per-account and per-character data, which comes in a follow-up PR.
The sources move from
ce.ajneb97tonet.tfminecraft.conditionalevents. The POM builds against Paper 1.21.10 with Java 21, and the jar is namedconditionalevents-<version>.jar. exp4j is still shaded, now relocated under our package. ItemsAdder's public API artifact (dev.lone:api-itemsadder:4.0.10) is no longer downloadable, so the build uses the pinned ItemsAdder 4.0.18 jar from ServerAssets throughprepare-release.sh, as BirdMessenger does. CI therefore needs this repository added to theDEPS_TOKENorganisation secret. The plugin name and data folder stayConditionalEvents, so Main's events and player files load unchanged. Upstream changed only six Java files between 4.80.1 (what the servers run) and 4.80.3, and no resources.I removed the update checker and bStats, as in Codex, along with the
update_notificationsetting. An existing config that still has the key is fine.api-versionis now1.21.10.mvn clean packagepasses locally, and the shaded jar passesplugin-artifact.py. Upstream has no tests.🤖 Generated with Claude Code