test(charts): cover crosshair repaints during data motion

[tannerlinsley]

What this covers

Adds a regression test for #208, reported by @toomingos. The clock fix in #222 already fixes the frozen crosshair, this test covers a data animation repainting the guide on every presentation frame.

The test checks that the spring advances, keeps the same guide element, and leaves no scheduled frames after cleanup.

Verification

• Chromium, Firefox and WebKit: the 1.1.0 baseline stays at 42.11 px through eight repaints. Current main moves to 183.703 px.
• Test-only change, no runtime code, dependency or bundle-budget changes.
• pnpm validate: all 19 tasks pass, including 2,225 main-suite tests, types, bundle budgets and packed consumers.
• Maintained example builds pass. All 188 generated preview assets are unchanged, only their source hash is refreshed.

The fix is merged but not published on npm yet. Version PR #220 is still pending.

Follow-up regression coverage for #208.

Summary by CodeRabbit

• Tests
  • Expanded chart testing to check that crosshair movement remains consistent during repeated chart updates and that redraws preserve the guide line. Also verified that animation frames are cleaned up afterward.

[changeset-bot]

⚠️ No Changeset found

Latest commit: bf63eb7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8f9e0ef3-4b45-4ec3-93f6-35f76dab72bd

📥 Commits

Reviewing files that changed from the base of the PR and between ba6b647 and bf63eb7.

📒 Files selected for processing: 2

• benchmarks/conformance/previews/manifest.json
• packages/charts-core/src/motion.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Walkthrough

The preview manifest’s sourceHash value changed. A regression test was added to check crosshair spring updates during repeated presentation-point repaints.

Changes: Preview manifest

Layer / File(s)	Summary
Update preview source hash benchmarks/conformance/previews/manifest.json	The manifest’s sourceHash value changed. Other manifest entries remain unchanged.

Crosshair repaint test

Layer / File(s)	Summary
Verify crosshair spring updates packages/charts-core/src/motion.test.ts	The test checks that eight frame updates repaint focus, the crosshair guide line moves toward its target while retaining its DOM identity, and cleanup leaves no pending frames.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to bf63e

The regression test and preview metadata changes appear mergeable with normal validation.

Pre-merge checks: 5

Passed checks: 5 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely identifies the main change: adding chart regression coverage for crosshair repaints during data motion.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit bf63eb7

Command	Status	Duration	Result
nx run charts-workspace:ci-distributed	✅ Succeeded	2m 33s	View ↗
nx run charts-workspace:package-check	✅ Succeeded	<1s	View ↗
nx run charts-workspace:benchmark-check	✅ Succeeded	<1s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-10-14 00:31:58 UTC