Skip to content

Dialogs are never fully closed #1269

Closed

Description

@lesha1201
TanStack.Table.-.Google.Chrome.2026-09-12.14-05-38.mp4

Description:
When you open 'All libraries' modal from the navigation bar and then close it, it becomes invisible but still interactive and blocks any outer interactions (including scroll).

Steps to reproduce:

  1. Go to any page (e.g. https://tanstack.com/start/latest)
  2. Press "Libraries" button in the top navigation bar. It should open "All libraries" modal
  3. Close "All libraries" modal
  4. Try to interact with the page

Context:

  • OS: Windows 11
  • Browser: tested in Chrome v153 and Firefox v155

Activity

  1. lesha1201 commented on Sep 12, 2026

    @lesha1201
    Author

    It seems all dialogs are affected:

    Merch.-.Google.Chrome.2026-09-12.14-24-10.mp4

    For example, if you open Cart, the whole page becomes unusable.

  2. changed the title [-]'All libraries' modal is never closed[/-] [+]Dialogs are never fully closed[/+] on Sep 12, 2026
  3. lesha1201 commented on Sep 12, 2026

    @lesha1201
    Author

    Checked preview builds of recent commits and it seems the issue appeared in this PR - #1253

  4. lesha1201 commented on Sep 12, 2026

    @lesha1201
    Author

    Confirmed that the issue is related to the recent upgrade of @tanstack/redact:

    • with @tanstack/redact@0.0.21 - works fine
    • with @tanstack/redact@0.1.0 (current version the project uses) - doesn't work
    • with @tanstack/redact@0.1.1 (the latest version) - doesn't work
  5. tannerlinsley commented on Sep 12, 2026

    @tannerlinsley
    Member

    This is live with @tanstack/redact@0.1.2 via #1271.

    Verified on tanstack.com: 30 docs navigations across Query, Router, and Start, browser back/forward, 15 library/cart/search open-close cycles, and mobile navigation. No browser or console errors. Closed dialogs are removed and pointer events are restored, so the page stays usable.

    Refresh once to load the updated bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions