Repository navigation
feat(local): record executor_id and result in finish events - #1170
Open
shengzhaowei wants to merge 1 commit into
Open
shengzhaowei wants to merge 1 commit into
shengzhaowei wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
In
local/skills/devflow/scripts/workflow_state.py, thefinishcommand appended only{at, event: stage_<result>, stage}toevents. Thestartcommand'sstage_startedevent and theapprovecommand'sstage_approvedevent both carryexecutor_id, so a finished stage could not be traced to who ran it from the event log alone. This PR adds"executor_id": stage.get("executor_id")and"result": args.resultto the finish event. A new regression test (LifecycleTests.test_finish_event_records_executor_id_and_result) runsinit/prepare/assign/start/finishon a SOLO stage and asserts thestage_completedevent carriesexecutor_id == "solo-1"andresult == "completed".Scope
Compatibility
Events gain two fields; no field is removed or renamed, no migration, no version bump. Existing consumers that ignore unknown event fields are unaffected.
approve/statusbehavior is unchanged.Validation
Run locally on 2026-11-21, base d58a85a: validate_config OK (adapters=7 logical_roles=10 host_agents=6 artifacts=11); unittest 31 tests OK (incl. test_finish_event_records_executor_id_and_result); validate.sh [1/6]-[6/6] passed; build-classic-hosts.py --check OK; scan-secrets no leaks found; e2e tests passed (skipped=1); smoke-install passed; test-observability passed, source tree clean. Not run: go test, go vet, check-public.py — no Go or public-surface changes in this PR.
Safety