Skip to content

feat(local): record executor_id and result in finish events - #1170

Open
shengzhaowei wants to merge 1 commit into
Tencent:mainfrom
shengzhaowei:feat/finish-event-executor
Open

shengzhaowei wants to merge 1 commit into
Tencent:mainfrom
shengzhaowei:feat/finish-event-executor

Conversation

@shengzhaowei

Copy link
Copy Markdown

What changed

In local/skills/devflow/scripts/workflow_state.py, the finish command appended only {at, event: stage_<result>, stage} to events. The start command's stage_started event and the approve command's stage_approved event both carry executor_id, so a finished stage could not be traced to who ran it from the event log alone. This PR adds "executor_id": stage.get("executor_id") and "result": args.result to the finish event. A new regression test (LifecycleTests.test_finish_event_records_executor_id_and_result) runs init/prepare/assign/start/finish on a SOLO stage and asserts the stage_completed event carries executor_id == "solo-1" and result == "completed".

Scope

  • Platform core / API / runner
  • Public adapter / deployment
  • Classic
  • Portable
  • Shared behavior contract
  • Installer / CLI
  • Documentation only

Compatibility

Events gain two fields; no field is removed or renamed, no migration, no version bump. Existing consumers that ignore unknown event fields are unaffected. approve/status behavior is unchanged.

Validation

Run locally on 2026-11-21, base d58a85a: validate_config OK (adapters=7 logical_roles=10 host_agents=6 artifacts=11); unittest 31 tests OK (incl. test_finish_event_records_executor_id_and_result); validate.sh [1/6]-[6/6] passed; build-classic-hosts.py --check OK; scan-secrets no leaks found; e2e tests passed (skipped=1); smoke-install passed; test-observability passed, source tree clean. Not run: go test, go vet, check-public.py — no Go or public-surface changes in this PR.

Safety

  • I did not include credentials, internal endpoints, production data, or organization-specific infrastructure.
  • I preserved user files and unrelated changes.
  • I updated generated Classic host bundles when applicable.
  • I documented third-party content and licensing changes when applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant