Repository navigation
fix(workspace): show Docker build progress without default timeouts - #1175
Open
crispinhu27 wants to merge 1 commit into
Open
crispinhu27 wants to merge 1 commit into
crispinhu27 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Scope
Compatibility
Ship the platform and connected Runner together so workspace preparation can receive cancellation. Existing explicit Docker build limits still apply.
Validation
bash scripts/build-chatbot.shbuilt the frontend and passed 464 tests.go test -p=2 ./internal/httpapi ./internal/runner ./internal/runtime ./internal/engine -run 'Test(RunnerWorkspace|RunnerConversationWorkspace|ConversationWorkspace|DockerBuild)' -count=1 -timeout=120sandgo test ./internal/procwatch -count=1 -timeout=120spassed in local Docker.python3 scripts/check-public.pyandgit diff --checkpassed.main, a cold workspace image built through a local connected Runner with a cached Node base image and a deterministic test CLI. One Dockerfile step downloaded a 61.5 MiB Go SDK at about 64 KiB/s for 16m 20s. The conversation still showed that step at 10m 10s and 15m 10s. BuildKit exported the image after 16m 35s. The resulting workspace rango versionand executed the compiled test program.Safety