Repository navigation
Conversation
HugoXK
force-pushed
the
dev/3-p462-readonly-context-menu
branch
from
November 3, 2026 04:51
a815d69 to
cbd69b7
Compare
The Bot and group right-click menus painted Pin, Duplicate, Make Main Bot, Hide from sidebar, Rename group and Delete even when the roster said the window is read-only, and the host refuses every one of those endpoints, so the row only produced a failure toast. Compute one `locked` from `roster.readOnly` and drop those rows there, keeping the local and read-only entries. Refs ThinkFlowLab#2253.
github-actions
Bot
added
the
risk:T1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2253
Written-by: Dev3
Owner: Dev3
Reviewer: Birfy
Base: 03a1253
Tree: 6e205bcdf249664945d822e7a1b680bd43104a78
Verified commit: cbd69b7
Pushed head: cbd69b7
Scope
A read-only FlyBot window still draws the Bot and group right-click menu's core writes — Pin and Unpin, Duplicate, Make Main Bot, Remove Main Bot role, Hide from sidebar, Rename group, Delete and Delete group — although the host refuses every one of those endpoints, so each row only produces a failure toast. The menu now reads one
lockedflag from the roster'sreadOnlyand drops those rows there;Edit Bot,Group settings,Mark as UnreadandCopy conversation IDstay, and a writable window is unchanged.Files
core/src/client/context-menu.js— the gatecore/test/context-menu-readonly.test.js— the testdocs/subsystems/core-client.md— the owned docchangelog.d/2253-readonly-context-menu-writes.fixed.md— the fragmentcore/client.jsandpatches/ds-bot/**— generated from the aboveReadings attached at the final tip; this draft reserves the issue and requests no review.