Repository navigation
Conversation
HugoXK
force-pushed
the
dev/2-readonly-banner-reload
branch
from
November 3, 2026 04:51
cc34ba4 to
8fda22e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2247
Owner: Dev2
Claim-Id: ae99f17f04c0438ca64d71ddcfa6f1e9
Branch: dev/2-readonly-banner-reload
Base: 03a1253
Tree: f49adb785114bdf40eb3e419a58658eeff2aedb4
Verified commit: 8fda22e
Pushed head: 8fda22e
Scope — the read-only sidebar banner (wide and rail forms) carries a
Reloadcontrol outside the live region, and the client can ask for a fresh state answer that is applied even when the revision is unchanged, so a window that has become writable picks the change up without a page reload.Files
core/src/client/sidebar.js— the button in both banner formscore/src/client/sources.js,core/src/client/index.js— the fresh request and its in-flight guardcore/test/client-reload-state.test.js,core/test/sidebar-readonly-reload.test.js— the new casesdocs/subsystems/core-client.md,changelog.d/2247-readonly-banner-reload.fixed.mdcore/client.js,patches/ds-bot/**— the generated bundle and mirrorsReadings attached at the final tip; this draft reserves the issue and requests no review.