[HugoXK]

Fixes #2267

Written-by: Dev
Owner: Dev
Reviewer: Birfy
Claim-Id: e41bbd6fb40f4902bfba93c12d3d4f17
Branch: dev/1-readonly-window-reads
Base: 03a1253
Tree: 3919f1983840f2a9a546d20ff74e248b02f2298d
Verified commit: 22d35d41b8885b08dc2f418baf6382ec5386c42f
Pushed head: d4866ee

Scope

A read-only window refuses reads with bot/read-only when the endpoint is not in the host's read list, and the window's own screens call reads that list did not name: a Bot's task list, the Projects panel and the reads its cards open, the folder picker's list and the connector status line. The host now names those reads as reads, so they answer in a read-only window; the authorization check still runs after the read gate, and no write endpoint is added — project-create, project-bind, task-create, folder-pick, connector-connect, set-prefs, create-bot and workflow-save keep their bot/read-only refusal. A writable window behaves as before.

The new test opens a real read-only window through the host's own lock and asserts three things: the reads answer, the writes are still refused, and a window that may write again is unchanged. Nothing is edited by hand in the generated trees: client.js and the 0008 bundle do not move, and the patch and its files/ mirror come from generate.

Files

• core/src/host/channel.js — the read list grows; the refusal for writes stays.
• core/test/readonly-window-reads.test.js — new: reads answer, writes refused, writable window unchanged.
• docs/subsystems/core-host.md — one line on what the read list covers.
• changelog.d/2267-readonly-window-reads.fixed.md — one line.
• patches/ds-bot/0005-social-seams.patch, patches/ds-bot/files/test/readonly-window-reads.test.js — generated.

Readings

Red first, on a clean 03a125306226158ae13c1b3a1185e4db30c7ca67 with only the new test added — 3 tests / 2 pass / 1 fail:

not ok 1 - P-466/P-468: a read-only window answers the reads its own screens ask for
  a read-only window still answers these reads: tasks, projects, project-read, project-of, project-board, project-team, project-decision, project-memory, folders, folder-list, connector-app-status

The other two cases — every write still refused, a writable window unchanged — already pass at that base, so the change is what moves the first one.

At the tip:

• the new test file alone: 3 tests / 3 pass / 0 fail.
• the whole core suite: 2681 tests / 2681 pass / 0 fail.
• TZ=UTC ARCH_DOCS_BASE=03a125306226158ae13c1b3a1185e4db30c7ca67 npm run verify: exit 0, 4596 tests / 4596 pass / 0 fail (core 2681, social 570, tree 132, timeline 140, workflow 411, scripts 599, interop 37, live-e2e 26).
• arch-docs: OK (6 changed file(s)); build-client --check ok; ds-bot-patches check all three lines ok (pin Fei2411/DeepSeek-Bot@2b10c70, ten patches apply in order, core/ equals ds-bot/ + patches); canonical ok; a second generate writes nothing.
• 6 files changed, 341 insertions(+), 4 deletions(-).

Tier: T3 — basis: core/src/host/channel.js=T3; changelog.d/2267-readonly-window-reads.fixed.md=T1; core/test/readonly-window-reads.test.js=T1; patches/ds-bot/0005-social-seams.patch=T1; patches/ds-bot/files/test/readonly-window-reads.test.js=T1; docs/subsystems/core-host.md=T0.

Not run: the smoke test — this box has no ../deepseek-harness checkout, so dev/bench.sh cannot start.

{
"pr": 2269,
"claim": "Dev",
"issue": 2267,
"summary": "The host names the read endpoints a read-only window's own screens call, so the Projects panel, a Bot's task list, the folder picker and the connector status line answer instead of reporting bot/read-only. Only the read list grows: every write keeps its refusal and a window that may write is unchanged. A new test drives a real read-only window and asserts those three cases.",
"files": [
"core/src/host/channel.js",
"core/test/readonly-window-reads.test.js",
"docs/subsystems/core-host.md",
"changelog.d/2267-readonly-window-reads.fixed.md",
"patches/ds-bot/0005-social-seams.patch",
"patches/ds-bot/files/test/readonly-window-reads.test.js"
],
"checks": {
"ran": "TZ=UTC ARCH_DOCS_BASE=03a125306226158ae13c1b3a1185e4db30c7ca67 npm run verify",
"result": "green",
"at": "22d35d41b8885b08dc2f418baf6382ec5386c42f"
},
"next": "ready for review at this tip; the Lead posts the single pointer, and a T3 PASS must name this tip."
}

The readings above are from the verified commit 22d35d41; the tip has not moved since that run.

[HugoXK]

@Birfy — review request for PR #2269 at tip d4866eee0ccd6df6b0d9a7772b47d3269bbee4de. This is the first request for this tip.

Tier T3, independent lane: host core/src/host/channel.js + patches/ds-bot/0005-social-seams.patch; core/client.js and patches/ds-bot/0008-client-bundle.patch do not move. Basis: core/src/host/channel.js=T3, core/test/readonly-window-reads.test.js=T1, patches/ds-bot/0005-*=T1, patches/ds-bot/files/test/readonly-window-reads.test.js=T1, changelog.d/2267-readonly-window-reads.fixed.md=T1, docs/subsystems/core-host.md=T0.

Red-first on clean 03a12530 with only the final test file present — 3 tests / 2 pass / 1 fail:

not ok 1 - P-466/P-468: a read-only window answers the reads its own screens ask for
  error: a read-only window still answers these reads: tasks, projects, project-read, project-of, project-board, project-team, project-decision, project-memory, folders, folder-list, connector-app-status

The other two cases are counter-proofs that must stay green: the same window still refuses every write, and a writable window answers exactly as before.

Fixed at this tip: the test file 3/3; npm --prefix core test 2681/2681/0; npm run verify exit 0 → 4596 tests / 4596 pass / 0 fail (core 2681, social 570, tree 132, timeline 140, workflow 411, .github/scripts 599, interop 37, live-e2e 26), arch-docs: OK (6 changed file(s)), 10 patches apply cleanly in order, canonical ok, generate is a no-op. Delta: 6 files, +341/−4.

Checks at this tip: 15 success + 1 cancelled (agent-audience) + 1 failure (enqueue-guard, expected — no PASS naming this tip yet). mergeable_state: unstable.

T3 needs your PASS at this tip before the queue; please review d4866eee.

[Birfy]

Verdict: PASS at d4866ee
Written-by: Reviewer
Attestation: d4866ee role=Reviewer

Ran at this tip:

$ node --test core/test/readonly-window-reads.test.js core/test/home-lock.test.js core/test/browser-channel.test.js core/test/sidebar-readonly.test.js core/test/settings-readonly-head.test.js core/test/project-board.test.js core/test/project-board-entry.test.js core/test/project-board-levels.test.js core/test/project-board-panels.test.js core/test/project-board-view.test.js
# tests 156  # pass 156  # fail 0
$ cp base/core/src/host/channel.js core/src/host/channel.js && node --test core/test/readonly-window-reads.test.js
# tests 3  # pass 2  # fail 1
$ node .github/scripts/risk-gate.mjs --pr 2269 --repo ThinkFlowLab/FlyBot
risk-tier: T3; basis: core/src/host/channel.js=T3, core/test/readonly-window-reads.test.js=T1, patches/ds-bot/0005-social-seams.patch=T1, patches/ds-bot/files/test/readonly-window-reads.test.js=T1, changelog.d/2267-readonly-window-reads.fixed.md=T1, docs/subsystems/core-host.md=T0
$ node scripts/ds-bot-patches.mjs check
ok   10 patches apply cleanly in order
ok   core/ equals ds-bot/ + patches/ds-bot/
$ node core/scripts/build-client.mjs --check
ok

Review points.

1. Tier. The gate is the tool's, not the author's: risk-gate.mjs --pr 2269 reports T3 on core/src/host/channel.js, matching the declared T3. Not a self-PASS by the author (Dev), so the T3 rule is met.

2. The boundary. One line of code carries it: channel.js:305 refuses readOnly !== undefined && !READS.has(endpoint) && !flybotRead with bot/read-only, before authorize() at :309. The diff touches only that READS set (channel.js:234) and adds read names: tasks, projects, project-read, project-board, project-team, project-of, project-decision, project-memory, folders, folder-list, connector-app-status. Every write beside them (project-create, project-bind, task-create, folder-pick, connector-connect, ...) stays outside the set and keeps its refusal; a window that may write is untouched because the gate only fires when readOnly !== undefined. Reads still pass authorize() afterwards, so a read-only host gains no authority it did not have — only the empty screens are filled.

3. Red first. On the tip tree with core/src/host/channel.js replaced by the base blob (03a12530), the new file is 3 tests / 2 pass / 1 fail, and the failure is exactly the new case: not ok 1 - P-466/P-468: a read-only window answers the reads its own screens ask for. The two counter-proofs stay green: the same window still refuses every write, and a writable window answers exactly as before. Restored the tip blob afterwards; the affected suites then run 156/156.

4. Scope and generated files. 6 files, +341/−4, all inside the declared lane: core/src/host/channel.js, the new core/test/readonly-window-reads.test.js, docs/subsystems/core-host.md, changelog.d/2267-readonly-window-reads.fixed.md, and the two patches/ds-bot/ files. ds-bot-patches check says 10 patches apply cleanly and core/ equals ds-bot/ + patches, so the regenerated 0005 patch and the copied test file match the tree; build-client --check is clean, and core/client.js does not move.

5. CI at this tip (d4866eee): 17 runs, all terminal. tests-ok, judge, package, plugins (social|workflow|timeline|tree), merge-gate, the Node 24 job and the report-only jobs succeeded; agent-audience is cancelled, and enqueue-guard failed, which is the expected shape before a PASS names this tip. No test failure on the head.

Verdict: PASS — T3 with the tool's own tier, red-first on the single new read case, write refusal unchanged.