Repository navigation
Conversation
The DSH Agent row's menu painted Pin, Unpin and Remove DSH Agent, and a Session's menu painted Rename and Archive, even when the roster said the window is read-only: the host refuses set-flags, remove-agent, agent-rename and agent-archive for such a window, so the row only produced a failure toast. Compute one `locked` from `roster.readOnly` the way the Bot menu already does and drop those rows there; with every row hidden the menu draws nothing rather than an empty box. Refs ThinkFlowLab#2253.
github-actions
Bot
added
the
risk:T1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2271
Written-by: Dev3
Owner: Dev3
Reviewer: Birfy
Claim-Id: 10086412d5f44cf6a6c788d4df73bc08
Branch: dev/3-agent-menu-readonly
Base: 03a1253
Tree: bda73e4bcd35456be4e341f8852ecfcc8a35d5e2
Verified commit: ce30175
Pushed head: ce30175
Scope
A read-only FlyBot window still draws the DSH Agent menu's
Pin/UnpinandRemove DSH Agent, and a session menu'sRenameandArchive, although the host refuses all four (set-flags,remove-agent,agent-renameandagent-archiveare not reads) so each row only ends in a failure toast.AgentMenunow reads the roster's read-only sentence once, the same way the rest of the client does, and drops those four rows; a writable window keeps every row exactly as it is, and a menu whose every row is a write is not drawn at all instead of leaving an empty box.Files
core/src/client/context-menu.js— the gate inAgentMenucore/test/context-menu-agent-readonly.test.js— the test and its counter-proofsdocs/subsystems/core-client.md— the owned docchangelog.d/2271-agent-menu-readonly.fixed.md— the fragmentcore/client.js— the regenerated bundlepatches/ds-bot/0003-flybot-api-client.patch,patches/ds-bot/0008-client-bundle.patch,patches/ds-bot/files/test/context-menu-agent-readonly.test.js— the regenerated mirrorsReadings attached at the final tip; this draft reserves the issue and requests no review.