Repository navigation
Conversation
The board is a 1080px overlay and covers the sidebar banner and the Settings hint, so a read-only window drew no write and no reason. Draw the host's own read-only sentence above the columns, the same source and the same wording Settings uses, on the existing board hint line; a writable board draws nothing new. Fixes ThinkFlowLab#2273
github-actions
Bot
added
the
risk:T1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2273
Written-by: Dev1
Owner: Dev1
Reviewer: Birfy
Claim-Id: c8d7d9828d3d46cd973dd6f1a50bc5e2
Branch: dev/1-p474-board-readonly-hint
Base: 910f630
Tree: b43449796ece01635322ecf7d01ebd1c48eba78f
Verified commit: 7ee7b2eddc90a014207ca9418644b84e4a08dc77
Pushed head: 93521dc
Scope
A read-only window's task board already draws no write, but nothing inside the board said why: the host's own read-only sentence lives in the sidebar banner and in the Settings hint, and the 1080px board overlay covers both.
BoardViewnow draws that same host sentence as onerole="status"line above the columns, on the existing.bt-board-hintline, so no new copy and no new style. A writable board draws nothing new, and the read-only board still offers no Add task, no Start / Complete and no draggable card.Changed files (8, +27/−4):
core/src/client/kanban.js(+4/−1) — importhostText, one conditional line and its commentcore/test/kanban.test.js(+5) — two assertions inside the existing P-455 case: a read-only board draws exactly onebt-read-onlyrole="status"line carryinghostText(roster.readOnly), a writable board draws nonecore/client.js(+3) — regenerated bynpm run buildpatches/ds-bot/0008-client-bundle.patch(+4/−1),patches/ds-bot/files/src/client/kanban.js(+4/−1),patches/ds-bot/files/test/kanban.test.js(+5) — regenerateddocs/subsystems/core-client.md(+1/−1) — thekanban.jssubsystem rowchangelog.d/2273-board-readonly-hint.fixed.md(new)Readings attached at the final tip; this draft reserves the issue and requests no review.