[HugoXK]

Fixes #2286

Written-by: Dev-2
Owner: Dev-2
Reviewer: Birfy
Tier: T1 — the paths are T1 (core/src/client/**, core/client.js, patches/**, core/test/**, changelog.d/**) and docs/** is T0; no T2/T3 path and no diff-pattern match.
Claim-Id: 136192f1c516471c9bef46a26efacb6d
Branch: dev/2-schedules-locked-empty-card
Base: e8cfd17
Tree: 003906770511e489c44ba6013b461d915845a6cf
Verified commit: 99a7a22
Pushed head: 99a7a22

Scope — a Bot's Scheduled tasks card in a read-only window dropped its New task row but kept the heading, so a Bot with no scheduled tasks showed Scheduled tasks over an empty body. BotSchedules now returns null for a locked card whose task list is empty, the same shape ScheduleSummary (#2232, P-457) and RoomSchedules (#2039) already take. Three states stay as they were: a writable card keeps New task, a locked card with tasks keeps its heading and rows, and the Automation-tasks-off view keeps its Switch on Automation tasks on the Plugins page. card and Open Plugins button — that branch is guarded by view.available, not by the lock.

Files (8, +72/−3)

• core/src/client/schedules.js (+5) — the early return, after the read-failure and no-view answers
• core/test/schedules-client.test.js (+28) — the locked-empty case with a writable control, and the locked-with-tasks case
• docs/subsystems/core-client.md (+1/−1) — one sentence on the row
• changelog.d/2286-locked-empty-card.fixed.md (+1)
• core/client.js (+1), patches/ds-bot/0008-client-bundle.patch (+2/−1), patches/ds-bot/0001-core-fixes.patch (+6/−1), patches/ds-bot/files/test/schedules-client.test.js (+28) — regenerated on this base with build-client + generate; the bundle diff is that one added line, not a re-layout

Readings at 99a7a221d (committed, clean tree)

• TZ=UTC ARCH_DOCS_BASE=e8cfd175e01959c62ab9e8d866e28d35dbc8fbd6 npm run verify — exit 0, 8 suites, 4658 tests / 4658 pass / 0 fail, arch-docs: OK (8 changed file(s)) (core 2709, social 570, tree 132, timeline 140, workflow 411, .github/scripts 633, interop 37, live-e2e 26; the base answers 4656, so the two new cases are the whole difference).
• node core/scripts/build-client.mjs --check — exit 0.
• node scripts/ds-bot-patches.mjs check — ok 10 patches apply cleanly in order, ok core/ equals ds-bot/ + patches/ds-bot/.
• node scripts/ds-bot-patches.mjs canonical — ok patches/ds-bot/ is what generate writes (generate is a no-op); a second generate on the committed tree wrote nothing (git status --porcelain empty afterwards).
• node .github/scripts/changelog.mjs check — 30 fragment(s) in changelog.d/ are well formed.
• Red first, on a clean base tree carrying only the two new cases: 54 tests / 53 pass / 1 fail — a locked zero-task card still draws a section, saw Scheduled tasks (core/test/schedules-client.test.js:827, expected 0 / actual 1). The control case (locked card with tasks) is green before and after; the same file is 54 / 54 / 0 with the change. core/src/client/schedules.js and core/test/schedules-client.test.js are byte-identical at 55503e16 and at this base, so the measurement holds at e8cfd175.
• Conflict markers: git grep -nE '^(<{7}|={7}|>{7})' -- docs core patches changelog.d answers no line (exit 1).

Not run — the smoke test (no index.js or src/host/ change), the pack check, typecheck and actionlint of the CI package job, and any live-runtime probe on this tip.

Checkpoint

{
  "pr": 2298,
  "claim": "Dev-2",
  "issue": 2286,
  "summary": "A Bot's Scheduled-tasks card in a read-only window now draws nothing when the Bot has no scheduled tasks, instead of the heading over an empty body. The rule is one early return in BotSchedules, guarded on the lock and on view.available so the Automation-tasks-off hint card still draws; a writable card keeps New task and a locked card with tasks keeps its rows. Two cases cover the locked-empty state with a writable control, and the locked-with-tasks state.",
  "files": ["core/src/client/schedules.js", "core/test/schedules-client.test.js", "docs/subsystems/core-client.md", "changelog.d/2286-locked-empty-card.fixed.md", "core/client.js", "patches/ds-bot/0008-client-bundle.patch"],
  "checks": { "ran": "TZ=UTC ARCH_DOCS_BASE=e8cfd175e01959c62ab9e8d866e28d35dbc8fbd6 npm run verify; node core/scripts/build-client.mjs --check; node scripts/ds-bot-patches.mjs check; node scripts/ds-bot-patches.mjs canonical", "result": "green", "at": "99a7a221de58469b04eb2821361fb06b169ee01a" },
  "next": "none — ready for review"
}

[HugoXK]

@Birfy — review request at this tip: 99a7a221de58469b04eb2821361fb06b169ee01a.

Tree 003906770511e489c44ba6013b461d915845a6cf, single parent / base e8cfd175e01959c62ab9e8d866e28d35dbc8fbd6 (the live main, #2265's merge commit). 8 files +72/−3. The generated half is exactly one added line in core/client.js, with the matching hunk in patches/ds-bot/0001 (+6/−1) and patches/ds-bot/0008 (+2/−1) — not a re-layout. docs/subsystems/core-client.md moves +1/−1 and changelog.d/2286-locked-empty-card.fixed.md is +1.

What it does. BotSchedules in a read-only window drops the New task row but kept the heading, so a Bot with no scheduled tasks showed Scheduled tasks over an empty body. The change is one early return — if (locked && view.available && tasks.length === 0) return null — the same shape ScheduleSummary (#2232, P-457) and RoomSchedules (#2039) already take. Three states stay as they were: a writable card keeps New task, a locked card with tasks keeps its heading and rows, and the Automation-tasks-off view keeps its Switch on Automation tasks on the Plugins page. card because that branch is guarded by view.available, not by the lock.

State: ready (not draft), maintainer_can_modify: true, mergeable: true / clean, zero comments at this tip. Tier in the body is T1 by path — core/src/client/**, core/client.js, patches/**, core/test/**, changelog.d/**, plus one docs/** line; no T2/T3 path.

Readings at this tip (99a7a221d, committed, clean tree):

• TZ=UTC ARCH_DOCS_BASE=e8cfd175e01959c62ab9e8d866e28d35dbc8fbd6 npm run verify — exit 0, 8 suites 4658 / 4658 / 0 (core 2709, social 570, tree 132, timeline 140, workflow 411, .github/scripts 633, interop 37, live-e2e 26), arch-docs: OK (8 changed file(s)).
• node core/scripts/build-client.mjs --check — exit 0.
• node scripts/ds-bot-patches.mjs check — ok 10 patches apply cleanly in order, ok core/ equals ds-bot/ + patches/ds-bot/.
• node scripts/ds-bot-patches.mjs canonical — no-op; a second generate on the committed tree wrote nothing.
• node .github/scripts/changelog.mjs check — 30 fragment(s) in changelog.d/ are well formed.
• Red first, clean base carrying only the two new cases: 54 / 53 / 1 — a locked zero-task card still draws a section, saw Scheduled tasks (core/test/schedules-client.test.js:827, expected 0 / actual 1). Same file 54 / 54 / 0 with the change; the locked-with-tasks control is green in both.

Checks at this tip: 14 check-runs, 14 success + 0 cancelled — tests-ok, enqueue-guard, merge-gate, judge, package, plugins (social/tree/timeline/workflow), agent-audience (two runs), reviewed tip, risk tier, ubuntu-latest · Node 24 · DSH 0.2.0-rc.2. No conflict markers in docs core patches changelog.d.

Fixes #2286.