Repository navigation
2026.10.21: set specs, prices and aliases from the model table - #336
Merged
Merged
Conversation
The edit dialog's Models section showed an unknown context window ("—")
and "Unpriced" for a model but offered no way to change either; specs and
aliases were only reachable from hover buttons in the list's model popover,
and prices from the Billing section. These are now entry points where the
problem is shown. They open the existing dialogs, so price sheets and
aliases work exactly as before.
- Models section (editing an upstream that is already in the config): the
context window cell opens Model specs ("Unknown · Set" when unknown); the
price cell opens the price sheet dialog ("Unpriced · Set price"); a row
menu (the ⋯ button and right-click, same items) has Specs…, Set price…,
Add alias…, and Remove for models added by hand; aliases listing a model
are marked after its name. Unchecked models can be set up too.
- Below the table: the unpriced note gets a Set price button; a grey line
says how many enabled models have an unknown context window and that
clients taken over fall back to their own default.
- Set price goes the same way as Billing's: a custom sheet is edited with
the model added as an override; on the default sheet a new sheet is
created, now prefilled with the upstream's name and with the upstream
preselected as its user, so it switches at once and the next Set price
edits that sheet instead of creating another.
- Model specs and new-alias dialogs report the written config version, so
the edit dialog keeps saving against the latest one.
- List: the Models cell shows a dropdown arrow; the popover (now 30rem)
has an always-visible row menu instead of hover-only buttons, marks
unpriced models and unknown context windows, and its footer reads
"Manage models…".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Edit upstream → Models, a model with an unknown context window shows "—" and one without a price shows "Unpriced", but neither cell does anything. Specs and aliases were only reachable from buttons that appear when hovering a row in the list's model popover, and prices from the Billing section, so the settings looked missing (see #335).
Change
The places that show the problem become entry points. They open the existing dialogs (Model specs, price sheet, new alias), so price sheets and aliases keep their current rules; no new dialogs, config fields or core changes.
Models section (when editing an upstream that is already in the config)
Set price follows Billing's existing path: a custom sheet opens in edit mode with the model added as an override; on the default sheet a new sheet is created. Two prefills are new: the sheet name defaults to the upstream's name (when free) and the upstream is preselected under "Upstreams using this price sheet". The upstream therefore switches to the new sheet when it is created, and the next Set price edits that sheet instead of creating another.
ModelSpecDialogandAliasDialognow pass the written config version toonSaved, so the edit dialog keeps saving against the latest version (as it already does for the nested price sheet and proxy dialogs).Upstream list
Verification
pnpm typecheck,pnpm vitest run(1211 tests pass), with new cases forunknownContext,catalogOfrows andsheetPrefill.Release
Also bumps the version to 2026.10.21 (
package.json,tauri.conf.json,Cargo.toml,Cargo.lock) and addsrelease-notes/2026.10.21.md, covering this change and #334. Core stays at v0.74.0.🤖 Generated with Claude Code