Repository navigation
fix(toolkits): stop doubling the account in toolkit policy patterns - #2343
Open
stanislavlysenko0912 wants to merge 1 commit into
Open
stanislavlysenko0912 wants to merge 1 commit into
stanislavlysenko0912 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a toolkit page, a policy set from a tool or folder row in the tree saved a pattern with the owner and connection twice, for example
google_gmail.user.me.user.me.gmail.users.labels.*. The pattern never matched, so the rule silently did nothing and write tools still asked for approval.The toolkit page passed the full tool id (
integration.owner.connection.tool) as the tree row name. Since #2062, rows inside an account section addowner.connectionto that name. The toolkit page now passesintegration.toolfor non-static tools, as the integration Tools tab already does. This also drops the redundantuser → <connection>levels from the tree.Verification
google_gmail.user.<conn>.gmail.users.drafts.*and...drafts.delete. Adrafts.create+drafts.deletecall over the toolkit MCP ran without an approval prompt.bun run format:checkbun run lintbun run typecheck(@executor-js/plugin-toolkitsand its dependents)bun run test(@executor-js/plugin-toolkitsand its dependents)Checklist
bun run changeset)