Repository navigation
Bump TiledArray; drop the =1 workaround in the GCC hardening flag - #752
Merged
Merged
Conversation
Picks up ValeevGroup/tiledarray#601, which stops DetectAlignSize from passing CMAKE_CXX_FLAGS as try_compile CMAKE_FLAGS, so a -D without a value in CXXFLAGS no longer breaks configure.
The TiledArray configure bug it worked around is fixed by the previous commit's bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves TiledArray to b0d8f0223, which includes ValeevGroup/tiledarray#601. With that fix, a
-Dwith no value inCXXFLAGSno longer breaks TiledArray's configure. So the Ubuntu Release job's hardening flag goes back to plain-D_GLIBCXX_ASSERTIONS(the=1workaround came in with #747).Two commits:
=1and its comment from.github/workflows/cmake.yml.Testing: before #601 merged, I configured its branch with valueless defines in
CXXFLAGS(macOS, AppleClang) and it succeeded. This PR's Ubuntu Release job is the check with GCC.