Skip to content

Remember the last checked access types in the TTD next/prev memory access dialog (Fixes #1109) - #1147

Merged
xusheng6 merged 1 commit into
devfrom
test_1109_remember_ttd_access_type
Aug 13, 2026
Merged

Remember the last checked access types in the TTD next/prev memory access dialog (Fixes #1109)#1147
xusheng6 merged 1 commit into
devfrom
test_1109_remember_ttd_access_type

Conversation

@xusheng6

@xusheng6 xusheng6 commented Jul 24, 2026

Copy link
Copy Markdown
Member

The dialog reset its Read/Write/Execute checkboxes on every open. Persist the selection with QSettings and restore it, falling back to the address-based guess only until the user picks something

…cess dialog (Fixes #1109)

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@xusheng6

Copy link
Copy Markdown
Member Author

Fixes #1109

@xusheng6
xusheng6 requested a review from plafosse July 30, 2026 21:34

@fuzyll fuzyll left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't entirely understand why #1109 is desirable and there's no notes/context, but I agree that this PR should implement everything necessary.

Is the issue that sometimes people want RWX in places and our defaults don't give that as an option? Just wondering if there's maybe a better way to have solved the usability issue than clobbering our defaults with the last selection. Users may still wind up needing to change the access type often, even with this change.

@xusheng6

Copy link
Copy Markdown
Member Author

I don't entirely understand why #1109 is desirable and there's no notes/context, but I agree that this PR should implement everything necessary.

Is the issue that sometimes people want RWX in places and our defaults don't give that as an option? Just wondering if there's maybe a better way to have solved the usability issue than clobbering our defaults with the last selection. Users may still wind up needing to change the access type often, even with this change.

Right now the dialog does not save the last selection of the RWX status. For example, if the user is manually tracing back a source of buffer, he would be repeatedly using this dialog to look for writes (W). Right now we do not save the last used selection, which means the dialog would open again with non of the RWX selected, so the user would have to do it every time

Thanks for reviewing and approving!

@xusheng6
xusheng6 merged commit 09203bb into dev Aug 13, 2026
1 check passed
@xusheng6
xusheng6 deleted the test_1109_remember_ttd_access_type branch August 13, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants