Skip to content

fix: check the two return values Code Analysis flags #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danalec wants to merge 1 commit into from
Closed

fix: check the two return values Code Analysis flags #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Virtual Display Driver (HDR)/MttVDD/Driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3248,7 +3248,13 @@ void SwapChainProcessor::Run()
/*
AvRevertMmThreadCharacteristics(AvTaskHandle);
*/ //error handling when reversing multimedia thread characteristics
if (AvRevertMmThreadCharacteristics(AvTaskHandle))
if (!AvTaskHandle)
{
logStream.str("");
logStream << "Skipping revert: multimedia thread characteristics were never set.";
vddlog("d", logStream.str().c_str());
}
else if (AvRevertMmThreadCharacteristics(AvTaskHandle))
{
logStream.str("");
logStream << "Multimedia thread characteristics reverted successfully.";
Expand Down Expand Up @@ -3832,7 +3838,13 @@ void IndirectDeviceContext::CreateMonitor(unsigned int index) {
// ==============================

// Create a container ID
CoCreateGuid(&MonitorInfo.MonitorContainerId);
HRESULT hrContainerId = CoCreateGuid(&MonitorInfo.MonitorContainerId);
if (FAILED(hrContainerId)) {
// MonitorInfo is zero-initialised, so MonitorContainerId would stay GUID_NULL
// and be handed to IddCxMonitorCreate as if it were valid. Bail out instead.
vddlog("e", "Failed to create container ID for monitor, skipping monitor creation");
return;
}
vddlog("d", "Created container ID");

IDARG_IN_MONITORCREATE MonitorCreate = {};
Expand Down