Repository navigation
Conversation
In list mode the item's box sits inside a Gtk::Button and the left-click GestureClick was attached to that box. GTK 4.18's button consumes the primary click, so the gesture never fired and nothing was launched. Connect on_click() to button.signal_clicked() instead; the right-click and long-press controllers stay on the box. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
The failing "Check code style with uncrustify" job isn't about this change: it fails while building uncrustify ("Compatibility with CMake < 3.5 has been removed from CMake", "Configuring incomplete"), the same as on |
Collaborator
|
Fixing uncrustify is on my TODO still, my apologies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #577.
In list mode the item's box sits inside a
Gtk::Button, and the left-clickGestureClickwas attached to that box. GTK 4.18's button consumes the primary click, so the gesture never fired and nothing was launched. Connecton_click()tobutton.signal_clicked()instead (added tosignalslike the others); the right-click and long-press controllers stay on the box.Tested with GTK 4.18.6: list-mode items launch on left click again. Grid mode doesn't use this code path.
🤖 Generated with Claude Code