Stop JS3 from silently hanging if simd is not supported - #312
Open
justinmichaud wants to merge 1 commit into
Open
Stop JS3 from silently hanging if simd is not supported#312justinmichaud wants to merge 1 commit into
justinmichaud wants to merge 1 commit into
Conversation
… compilation error promise rejections so that they are not silently ignored.
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
justinmichaud
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop JS3 from silently hanging if simd is not supported. Pipe through compilation error promise rejections so that they are not silently ignored.
In particular, this is useful for 32-bit jsc, which does not support wasm simd. Today, JS3 will just hang in the middle of a test run.