Skip to content

test: read the TopBar trigger look once the hover transition is done - #29

Merged
wiifree merged 1 commit into
mainfrom
fix/topbar-hover-transition
Oct 29, 2026
Merged

wiifree merged 1 commit into
mainfrom
fix/topbar-hover-transition

Conversation

@wiifree

@wiifree wiifree commented Oct 29, 2026

Copy link
Copy Markdown
Member

transition-colors also runs with reduced motion, so the border colour read right after hover() was sometimes a value in between and the comparison failed now and then.

What and why

Checklist

  • Vue and React with an identical API and identical DOM (parity case in packages/parity/src/cases.ts)
  • Accessibility according to WCAG 2.2 AA – keyboard, focus, names, states (rules in docs/accessibility.md, workflow in CONTRIBUTING.md)
  • Stories in both Storybooks, texts in English
  • Tests: pnpm lint, pnpm typecheck, pnpm test (targeted E2E specs for interaction)
  • AI docs updated (pnpm --filter @wirecore/wirelayer-mcp collect), changeset added (pnpm changeset)
  • New dependencies: license on the allowlist (pnpm licenses:check), optional as a peerDependency
  • All commits with Signed-off-by (git commit -s, DCO)

transition-colors also runs with reduced motion, so the border colour read right after hover() was sometimes a value in between and the comparison failed now and then.

Signed-off-by: Florian Laabs <florian.laabs@wirecore.net>
@wiifree
wiifree merged commit 8df38bc into main Oct 29, 2026
18 checks passed
@wiifree
wiifree deleted the fix/topbar-hover-transition branch October 29, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant