Repository navigation
Conversation
matnun-br
requested review from
clement911 and
greg-betterreports
and
a balanced review from Copilot
November 5, 2026 01:36
There was a problem hiding this comment.
🟡 Changes recommended
Removing the public constructor breaks existing callers and compiled consumers, while ignoring configured JSON options when parsing HTTP errors can silently discard error messages.
2 open issues
What changed in this PR
This PR adds server-provided HTTP error messages to GraphQLHttpException, improving diagnostics for failed GraphQL requests.
Changes:
- Adds an HTTP error model and a converter supporting string and message-object error formats.
- Parses error details from unsuccessful HTTP responses, with a fallback for JSON parsing failures.
- Includes extracted messages in the exception text.
| File | Description |
|---|---|
| GraphQLSharp/Serialization/GraphQLHttpErrorMessageConverter.cs | Converts supported error formats into message lists. |
| GraphQLSharp/Client/Response/GraphQLHttpError.cs | Holds error messages and request/response context. |
| GraphQLSharp/Client/GraphQLClient.cs | Reads HTTP error details before throwing an exception. |
| GraphQLSharp/Client/Exceptions/GraphQLHttpException.cs | Accepts the error model and includes messages in diagnostics. |
Review effort: Balanced
matnun-br
changed the title
matnun-br
marked this pull request as ready for review
November 5, 2026 01:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.