Skip to content

Kilted support - #499

Open
jimmy-mcelwain wants to merge 2 commits into
Yaskawa-Global:mainfrom
jimmy-mcelwain:kilted_support
Open

Kilted support#499
jimmy-mcelwain wants to merge 2 commits into
Yaskawa-Global:mainfrom
jimmy-mcelwain:kilted_support

Conversation

@jimmy-mcelwain

Copy link
Copy Markdown
Collaborator

Adds kilted support.

Depends on Yaskawa-Global/micro_ros_motoplus#22 (and consequently Yaskawa-Global/micro_ros_motoplus#21) and https://github.com/Yaskawa-Global/micro_ros_motoplus_buildscripts/pull/167.

I added --ipc=host to the docker run example because otherwise the micro-ros agent wasn't publishing properly. I could list topics and nodes, but not echo. But after adding --ipc=host, it worked.

I haven't thoroughly tested. I loaded on a binary that I built and verified that /joint_states was publishing.

I don't know when Lyrical will make it upstream for micro-ros, but hopefully having done all of this will make it easier to port once it does come.

@jimmy-mcelwain jimmy-mcelwain added the enhancement New feature or request label Jun 12, 2026
@gavanderhoorn

gavanderhoorn commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

I haven't tested anything, but as a first comment: please update the build VS proj workflow to add Kilted to the matrix.

It will fail until Yaskawa-Global/micro_ros_motoplus#22 is merged, but that would be a good way to figure out whether this PR can be merged or not.

@gavanderhoorn gavanderhoorn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as changes requested to avoid accidental merge.

@jimmy-mcelwain

Copy link
Copy Markdown
Collaborator Author

please update the build VS proj workflow to add Kilted to the matrix

I haven't done that yet because I do not know what the name of the micro_ros_motoplus release will be (since it has the build date in it). Should I have a placeholder, or should I put up a Kilted pre-release to micro_ros_motoplus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants