Kilted support - #499
Open
jimmy-mcelwain wants to merge 2 commits into
Open
Conversation
jimmy-mcelwain
force-pushed
the
kilted_support
branch
from
June 12, 2026 20:23
6944417 to
c6826a4
Compare
Collaborator
|
I haven't tested anything, but as a first comment: please update the It will fail until Yaskawa-Global/micro_ros_motoplus#22 is merged, but that would be a good way to figure out whether this PR can be merged or not. |
gavanderhoorn
requested changes
Jul 9, 2026
gavanderhoorn
left a comment
Collaborator
There was a problem hiding this comment.
Marking as changes requested to avoid accidental merge.
Collaborator
Author
I haven't done that yet because I do not know what the name of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds kilted support.
Depends on Yaskawa-Global/micro_ros_motoplus#22 (and consequently Yaskawa-Global/micro_ros_motoplus#21) and https://github.com/Yaskawa-Global/micro_ros_motoplus_buildscripts/pull/167.
I added
--ipc=hostto the docker run example because otherwise the micro-ros agent wasn't publishing properly. I could list topics and nodes, but not echo. But after adding--ipc=host, it worked.I haven't thoroughly tested. I loaded on a binary that I built and verified that
/joint_stateswas publishing.I don't know when Lyrical will make it upstream for micro-ros, but hopefully having done all of this will make it easier to port once it does come.