You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Let any requester clear a maintainer block in the label workflow #2026
A maintainer re-request of a blocking maintainer does not clear the block. The PR stays awaiting-author.
Context
A maintainer's CHANGES_REQUESTED review is a durable block. Only two events clear it: the PR author re-requests that maintainer, or the maintainer re-requests themselves. If any other person re-requests the blocker, nothing changes.
Example: #1905. taltas requested changes. The author pushed new commits but did not re-request. edelauna then re-requested taltas. The PR stayed awaiting-author, and no CodeRabbit labels appeared.
GitHub lets only the author and people with triage or write access request reviewers. A review_requested event that names the blocker is already a valid signal.
Proposal
Remove the actor check in the review_requested loop (actorLogin !== authorLogin && actorLogin !== requested).
Keep these rules: team requests never clear a block, the request must not be older than the blocking review, a timeline error keeps the block, and review_request_removed never clears a block.
When the block clears and CI passes, the existing flow adds awaiting-coderabbit and coderabbit-review-active. No new label code is needed.
Change the existing test that expects a third-party re-request to keep the block. Add tests for: a third-party re-request, a team request, an older request, and the CodeRabbit labels after the block clears.
Open question
This lets any user with request rights bypass the author. To limit it to maintainers, add a permissionFor check on the actor.
Activity
fix: let any requester clear a maintainer block in the label workflow (…