Skip to content

[Fix] Subtasks process queued feedback before returning - #1318

Open
zoomote[bot] wants to merge 11 commits into
mainfrom
fix/queued-input-approval-1k43hlevwo6pk
Open

zoomote[bot] wants to merge 11 commits into
mainfrom
fix/queued-input-approval-1k43hlevwo6pk

Conversation

@zoomote

@zoomote zoomote Bot commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

What changed

Messages sent while the active task is streaming are added to that task's queue before the task can finish. A focused VS Code e2e delays child completion, sends a queued instruction, verifies the child processes it, and only then permits the parent to resume.

API input now carries origin api on every route. The streaming route and the webview route (invoke to queueMessage) both store it on the queued message. Task#ask does not use an api message to approve a protected ask (command, use_mcp_server, tool). The message stays queued until the user answers the ask.

The new queued-input e2e covers streaming API-origin input on a protected command ask. It does not cover the webview route. Focused unit tests cover API-origin propagation through the webview queue branches.

Known limitation (PR-6): webview-origin queued input can still approve a protected ask. This behavior remains unchanged.

Why this change was made

Queued instructions could lose a race with delegated child completion. The lifecycle-side approval and durable-feedback behavior now lives on main; this PR is intentionally limited to ensuring streaming input reaches the active child before that lifecycle logic runs, plus regression coverage for the full child-to-parent boundary.

Impact

Subtasks receive queued steering before they can return control to their parent. No image normalization, validation, or broader public API contract changes are included.

Linked work items

Closes #1308
Tracked under #355

Related PRs

@codecov

codecov Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/extension/api.ts 87.50% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Review status

This PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.

Current step: Resolve the merge conflicts. The review sequence resumes after the branch is mergeable.

Review-state labels are managed by this workflow; do not edit them manually. community-approved is managed the same way — do not add or remove it manually. It signals a fresh community code approval for the current head as an advisory priority only; maintainer review is still required.

@github-actions github-actions Bot added has-conflicts PR has merge conflicts with the base branch and removed has-conflicts PR has merge conflicts with the base branch labels Aug 30, 2026
@zoomote
zoomote Bot force-pushed the fix/queued-input-approval-1k43hlevwo6pk branch from 0cc0096 to a83534e Compare September 5, 2026 00:50
@zoomote zoomote Bot changed the title [Fix] Queued messages no longer approve pending actions [Fix] Subtasks process queued feedback before returning Sep 5, 2026
@edelauna

edelauna commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@edelauna
edelauna force-pushed the fix/queued-input-approval-1k43hlevwo6pk branch from a4fff39 to 42b422b Compare October 9, 2026 21:53
@edelauna
edelauna marked this pull request as ready for review October 11, 2026 16:27
@github-actions github-actions Bot added coderabbit-review-active Required CI passed; CodeRabbit review is active awaiting-coderabbit Waiting for CodeRabbit to approve the latest commit has-conflicts PR has merge conflicts with the base branch and removed coderabbit-review-active Required CI passed; CodeRabbit review is active awaiting-coderabbit Waiting for CodeRabbit to approve the latest commit labels Oct 11, 2026
@github-actions github-actions Bot added coderabbit-review-active Required CI passed; CodeRabbit review is active awaiting-coderabbit Waiting for CodeRabbit to approve the latest commit and removed coderabbit-review-active Required CI passed; CodeRabbit review is active awaiting-coderabbit Waiting for CodeRabbit to approve the latest commit labels Oct 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author PR is waiting for the author to address requested changes has-conflicts PR has merge conflicts with the base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Queued messages interfere with tool responses that require user interaction

3 participants