Repository navigation
[Fix] Subtasks process queued feedback before returning - #1318
zoomote[bot] wants to merge 11 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: Resolve the merge conflicts. The review sequence resumes after the branch is mergeable. Review-state labels are managed by this workflow; do not edit them manually. |
0cc0096 to
a83534e
Compare
|
@CodeRabbit review |
✅ Action performedReview finished.
|
a4fff39 to
42b422b
Compare
What changed
Messages sent while the active task is streaming are added to that task's queue before the task can finish. A focused VS Code e2e delays child completion, sends a queued instruction, verifies the child processes it, and only then permits the parent to resume.
API input now carries origin
apion every route. The streaming route and the webview route (invoketoqueueMessage) both store it on the queued message.Task#askdoes not use anapimessage to approve a protected ask (command,use_mcp_server,tool). The message stays queued until the user answers the ask.The new queued-input e2e covers streaming API-origin input on a protected command ask. It does not cover the webview route. Focused unit tests cover API-origin propagation through the webview queue branches.
Known limitation (PR-6): webview-origin queued input can still approve a protected ask. This behavior remains unchanged.
Why this change was made
Queued instructions could lose a race with delegated child completion. The lifecycle-side approval and durable-feedback behavior now lives on
main; this PR is intentionally limited to ensuring streaming input reaches the active child before that lifecycle logic runs, plus regression coverage for the full child-to-parent boundary.Impact
Subtasks receive queued steering before they can return control to their parent. No image normalization, validation, or broader public API contract changes are included.
Linked work items
Closes #1308
Tracked under #355
Related PRs