fix: resolve Basic Validation audit failures (brace-expansion, fast-xml-parser) - #1347
Open
HarithaVattikuti wants to merge 1 commit into
Open
fix: resolve Basic Validation audit failures (brace-expansion, fast-xml-parser)#1347HarithaVattikuti wants to merge 1 commit into
HarithaVattikuti wants to merge 1 commit into
Conversation
- Upgrade fast-xml-parser to 5.10.1 (fixes GHSA-8r6m-32jq-jx6q) - Add package.json override to force brace-expansion >=5.0.8 across all transitive dependencies (fixes GHSA-mh99-v99m-4gvg) without downgrading jest/ts-jest - Refresh .licenses/npm cache to match updated dependency tree - Rebuild dist/setup and dist/cache-save npm audit now reports 0 vulnerabilities. Pre-existing test suite failures (7 suites, ESM/jest teardown issue) verified unrelated to this change - identical on unmodified main with node 24. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses npm audit --audit-level=high failures in the basic-validation.yml workflow by updating direct and transitive Node dependencies, and then refreshing generated artifacts (lockfile, bundled dist/ outputs, and .licenses cache) to match the new dependency graph.
Changes:
- Add an npm
overridesrule to force patchedbrace-expansionversions for transitive dependencies. - Upgrade
fast-xml-parser(and its dependency tree) to versions that remediate the referenced security advisory. - Regenerate
package-lock.json,dist/*bundles, and.licenses/npm/*entries to align with updated dependencies.
Reviewed changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds overrides to ensure patched brace-expansion is used in the dependency tree. |
| package-lock.json | Updates resolved dependency versions (notably brace-expansion and fast-xml-parser) and removes older nested vulnerable copies. |
| dist/setup/index.js | Rebuilt bundled output to incorporate updated dependencies and their security fixes. |
| dist/cache-save/index.js | Rebuilt bundled output to incorporate updated dependencies and their security fixes. |
| .licenses/npm/xml-naming-0.3.0.dep.yml | Adds license metadata for newly introduced xml-naming@0.3.0. |
| .licenses/npm/xml-naming-0.1.0.dep.yml | Normalizes metadata formatting to match the refreshed license cache. |
| .licenses/npm/path-expression-matcher.dep.yml | Updates recorded version to match the new dependency tree. |
| .licenses/npm/is-unsafe.dep.yml | Updates recorded version to match the new dependency tree. |
| .licenses/npm/fast-xml-parser.dep.yml | Updates recorded version to match the new dependency tree. |
| .licenses/npm/concat-map.dep.yml | Removes license metadata for a dependency no longer present in the tree. |
| .licenses/npm/brace-expansion.dep.yml | Updates recorded version to match the new dependency tree. |
| .licenses/npm/brace-expansion-1.1.15.dep.yml | Removes license metadata for a dependency no longer present in the tree. |
| .licenses/npm/balanced-match.dep.yml | Adds license metadata for the updated balanced-match version in the tree. |
| .licenses/npm/balanced-match-1.0.2.dep.yml | Removes license metadata for a dependency no longer present in the tree. |
| .licenses/npm/@nodable/entities.dep.yml | Updates recorded version to match the new dependency tree. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
npm audit --audit-level=highfailure inbasic-validation.ymlChanges
fast-xml-parserto 5.10.1, fixing GHSA-8r6m-32jq-jx6qpackage.jsonoverridesentry to pin transitivebrace-expansionto^5.0.8, fixing GHSA-mh99-v99m-4gvg in nested deps of@actions/cache,glob, andtest-exclude— without the breakingts-jest@27downgrade thatnpm audit fix --forcewould otherwise pull in.licenses/npm/*cache to match the updated dependency treedist/setup/index.jsanddist/cache-save/index.jsValidation
npm audit --audit-level=high→ 0 vulnerabilitieslicensed status→ 48 dependencies checked, 0 errorsnpm run format-check→ passnpm run lint→ passnpm run build→ passnpm test→ 69/69 tests pass (7 pre-existing, unrelated test-suite failures due to a jest/ESM teardown issue reproduced identically on unmodifiedmainwith Node 24 — out of scope for this fix)