Skip to content

Fixs the release issue #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LSantha merged 2 commits into from
Aug 11, 2026
Merged

Fixs the release issue #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5df3968
Fixs the release issue
alwinjoseph02 Aug 11, 2026
af42243
Downgrade the core-cif-component version in it/site
alwinjoseph02 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ jobs:
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
ARTIFACTORY_CLOUD_USER: ${{ secrets.ARTIFACTORY_CLOUD_USER }}
ARTIFACTORY_CLOUD_PASS: ${{ secrets.ARTIFACTORY_CLOUD_PASS }}
MAVEN_CENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
MAVEN_CENTRAL_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}

- name: Clean up secrets
if: always()
Expand Down
2 changes: 1 addition & 1 deletion it/site/all/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>com.adobe.commerce.cif</groupId>
<artifactId>cif-components-it-site</artifactId>
<version>2.18.7-SNAPSHOT</version>
<version>1.0.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
15 changes: 14 additions & 1 deletion it/site/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@
</parent>

<artifactId>cif-components-it-site</artifactId>
<version>2.18.7-SNAPSHOT</version>
<!-- Independent version for the it/site test site, deliberately decoupled from the CIF release
version so the profile-gated classic/* modules (which the release plugin never rewrites)
stay consistent. Do not bump this on release. -->
<version>1.0.0-SNAPSHOT</version>
<packaging>pom</packaging>
<name>CIF IT Site</name>
<description>CIF IT Site — integration-test site for AEM CIF Core Components</description>
Expand Down Expand Up @@ -460,6 +463,16 @@ Bundle-DocURL:
<version>${core.wcm.components.version}</version>
</dependency>
<!-- CIF Core Components -->
<!-- Compile-time only (the bundle is provided by the AEM runtime, not embedded). Managed
centrally here so the whole it/site test site pins a single CIF Core version. it/site is
a standalone reactor decoupled from the CIF release reactor, so THIS is the one line to
bump when retargeting the test site at a newer CIF Core version. -->
<dependency>
<groupId>com.adobe.commerce.cif</groupId>
<artifactId>core-cif-components-core</artifactId>
<version>2.18.4</version>
<scope>provided</scope>
</dependency>
<!-- CIF SDK API -->
<dependency>
<groupId>com.adobe.aem</groupId>
Expand Down
2 changes: 1 addition & 1 deletion it/site/ui.apps.structure/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<parent>
<groupId>com.adobe.commerce.cif</groupId>
<artifactId>cif-components-it-site</artifactId>
<version>2.18.7-SNAPSHOT</version>
<version>1.0.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
3 changes: 1 addition & 2 deletions it/site/ui.apps/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<parent>
<groupId>com.adobe.commerce.cif</groupId>
<artifactId>cif-components-it-site</artifactId>
<version>2.18.7-SNAPSHOT</version>
<version>1.0.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down Expand Up @@ -133,7 +133,6 @@
<dependency>
<groupId>com.adobe.commerce.cif</groupId>
<artifactId>core-cif-components-core</artifactId>
<version>2.18.7-SNAPSHOT</version>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion it/site/ui.config/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<parent>
<groupId>com.adobe.commerce.cif</groupId>
<artifactId>cif-components-it-site</artifactId>
<version>2.18.7-SNAPSHOT</version>
<version>1.0.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion it/site/ui.content/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<parent>
<groupId>com.adobe.commerce.cif</groupId>
<artifactId>cif-components-it-site</artifactId>
<version>2.18.7-SNAPSHOT</version>
<version>1.0.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
9 changes: 8 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,16 @@
<modules>
<module>it/content</module>
<module>it/http</module>
<module>it/site</module>
<module>ui.tests</module>
</modules>
<!-- it/site is intentionally NOT a reactor module. It builds as its own standalone
reactor (see .github/scripts/it-tests.js) and is versioned independently at
1.0.0-SNAPSHOT. Keeping it out of the reactor stops mvn release:prepare from
bumping its version (autoVersionSubmodules=true would otherwise force it to the
release version and strand the profile-gated it/site/classic/* modules, which the
release plugin never rewrites). Its only coupling to the CIF release is the
provided-scope core-cif-components-core dependency, managed centrally in
it/site/pom.xml and bumped manually when retargeting the test site. -->
</profile>
</profiles>

Expand Down
Loading