Repository navigation
ate-setup: settings for the router's route timeout, parked budget and ext_proc breaker - #2560
Open
Davanum Srinivas (dims) wants to merge 2 commits into
Open
Davanum Srinivas (dims) wants to merge 2 commits into
Davanum Srinivas (dims) wants to merge 2 commits into
Conversation
Davanum Srinivas (dims)
force-pushed
the
router-settings
branch
2 times, most recently
from
October 14, 2026 12:08
bf2a288 to
66dd6eb
Compare
Bowei Du (bowei)
added
area/dev-infra
area/network
kind/feature
Davanum Srinivas (dims)
force-pushed
the
router-settings
branch
6 times, most recently
from
October 22, 2026 12:37
9d95687 to
4c2b4d2
Compare
Davanum Srinivas (dims)
force-pushed
the
router-settings
branch
2 times, most recently
from
October 23, 2026 15:04
ee6dc28 to
968f0ca
Compare
--atenet-route-timeout and --atenet-parked-request-budget set the two router flags at install time; unset keeps the router defaults. A larger budget grows terminationGracePeriodSeconds by the same amount so parked requests finish during a rollout. Envoy dataplane only. applyWithAPIServerEnvHash now takes the decoded objects, so the system bundle is decoded once, the router flags are set, and the api-server env hash is stamped before the one apply.
ATE_ATENET_EXTPROC_MAX_REQUESTS (atenet.router.extprocMaxRequests, --atenet-extproc-max-requests) passes --extproc-max-requests to the router the way the route timeout and parked budget settings pass theirs. On a dense host 1536 synchronized execs overflowed the derived breaker of 2048 and Envoy answered 503 "reset reason: overflow"; the only way to raise it was a patch on the deployment.
Davanum Srinivas (dims)
force-pushed
the
router-settings
branch
from
October 24, 2026 11:56
968f0ca to
8af7e16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The router flags
--route-timeout,--parked-request-budgetand--extproc-max-requestscould only be set by a patch on the atenet-router deployment. At scale, the 5 s default parked budget and the derived ext_proc circuit breaker were the first limits hit.This adds three install settings,
ATE_ATENET_ROUTE_TIMEOUT,ATE_ATENET_PARKED_REQUEST_BUDGETandATE_ATENET_EXTPROC_MAX_REQUESTS, each with a flag and a config-file form. The installer validates them (positive values, envoy dataplane only), sets the flags on the router container in both deploy paths, grows the router'sterminationGracePeriodSecondswith the budget, and documents them.Verified with
gofmt -lon the touched Go files,go vet ./cmd/ate-setup/...,go test ./cmd/ate-setup/...(including the doc-drift tests) andhack/verify/boilerplate.sh.