Repository navigation
objectstore-plugin: storage settings come from ate-storage-config - #3197
Draft
SamPriyadarshi wants to merge 1 commit into
Draft
SamPriyadarshi wants to merge 1 commit into
SamPriyadarshi wants to merge 1 commit into
Conversation
The two objectstore-plugin sidecars had their storage settings copied inline in ate-api-server.yaml, atelet.yaml and both kind overlays. Nothing kept the copies in sync, and sidecars that disagree on the store lose snapshots: ate-api-server's sidecar copies and deletes what atelet's uploads. Both sidecars now read the ate-storage-config ConfigMap via envFrom, plus an optional ate-storage-credentials Secret, which kind uses for rustfs's static keys. ate-setup applies the environment's copy before the workloads, as it does ate-otel-config, including on the single-component redeploys. fake-atelet takes the sidecar's envFrom along with its env. The rustfs bucket-init Job keeps its values inline, because a Job's pod template is immutable. A test checks that they match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The object storage settings of the two objectstore-plugin sidecars were copied into four places (
ate-api-server.yaml,atelet.yamland both kind overlays), and nothing kept them in sync. This is part 1 of #2378, split as agreed on the issue: a staticate-storage-configConfigMap (GCS in the base, rustfs on kind) and an optionalate-storage-credentialsSecret (kind only), read viaenvFromby the sidecars only. Rendering them fromate-setupsettings for non-kind S3 installs is the follow-up.Part of #2378
There is no digest annotation, so editing
ate-storage-configrestarts nothing, as withate-otel-config. The file says to restart both workloads after a change. #2382 removes the existingate.dev/env-hashdigest. I can add a storage digest here if you want one.requireGCSin the snapshotcredentials suite now reads the backend from the ConfigMap.Tested on kind (gVisor lane only; no KVM here):
main, then upgraded withdeploy ate-systemfrom this branch. Server-side apply removed the old inline env, and both sidecars ran with the same settings, read from the ConfigMap and Secret.deploy apiserveranddeploy ateletwith no change rolled nothing. With the ConfigMap and Secret deleted, each of them recreated both.deploy ate-system --fake-data-planeand back: fake-atelet got the S3 settings.Not run on GKE. The rendered GCS env there is unchanged too.
Upgrade note: storage env that was added to a sidecar by hand with kubectl still overrides the ConfigMap, because server-side apply only removes what
ate-setupapplied.AI use: AI-assisted (code, tests and test runs). I reviewed and tested it.